Feat: allow fine tuning output record batch size for repartionionExec - #25176
Merged
kumarUjjawal merged 2 commits intoSep 11, 2026
Merged
Conversation
Rich-T-kid
force-pushed
the
rich-T-kid/override-buffer-batch-size
branch
from
September 10, 2026 19:40
a5d07f2 to
a45510b
Compare
Rich-T-kid
force-pushed
the
rich-T-kid/override-buffer-batch-size
branch
from
September 10, 2026 19:46
a45510b to
bf35583
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #25176 +/- ##
========================================
Coverage 81.91% 81.91%
========================================
Files 1132 1132
Lines 420570 421148 +578
Branches 420570 421148 +578
========================================
+ Hits 344490 344983 +493
- Misses 55764 55771 +7
- Partials 20316 20394 +78 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
2010YOUY01
approved these changes
Sep 11, 2026
| /// By default the coalescer targets [`SessionConfig::batch_size`]. Use | ||
| /// this method when you need a different batch size for a specific | ||
| /// `RepartitionExec` node without changing the global session config. | ||
| pub fn with_batch_size(mut self, batch_size: usize) -> Self { |
Contributor
There was a problem hiding this comment.
It should error for invalid input (batch_size is 0)
Contributor
Author
There was a problem hiding this comment.
true, updated the PR
Contributor
|
Thank you @Rich-T-kid and @2010YOUY01 for the review |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
RepartitionExeccoalesces output batches toSessionConfig::batch_size(typically 8192). Some callers need a different target size for a single repartition node without altering the global session config. This PR adds a builder method that makes that possible.What changes are included in this PR?
What is the testing strategy for this PR?
added 1 test to assert that SharedCoalescer produces the correctly fine-tuned target batch size
Are there any user-facing changes?
yes, user can now change the output batch size for repartionExec streams