fix: preserve scalar UDF bounds across FFI - #25142
Open
emecii wants to merge 1 commit into
Open
Conversation
Generated-by: Codex (GPT-5)
Author
|
@timsaucer, could you please add the required AI-generated with Codex (GPT-5). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
FFI_ScalarUDFsilently drops producer overrides of defaulted trait methods #22330.Rationale for this change
Foreign scalar UDFs currently lose custom
evaluate_bounds()behavior across the FFI boundary. The consumer falls back to an unbounded NULL interval, preventing interval analysis from using provider bounds.What changes are included in this PR?
evaluate_boundscallback toFFI_ScalarUDF.FFI_Intervalrepresentation.What is the testing strategy for this PR?
cargo test -p datafusion-ffi --features integration-testsAGENTS.mdcargo fmt --all -- --checkcargo clippy -p datafusion-ffi --all-targets --all-features -- -D warningswith only Rust 1.98 compatibility lint allowancesAre there any user-facing changes?
Yes. Foreign scalar UDFs now preserve custom interval bounds. The
FFI_ScalarUDFlayout changes, so this PR requires theapi changelabel.Generated-by: Codex (GPT-5)