Parse PostgreSQL MERGE DO NOTHING actions - #2468
Open
LucaCappelletti94 wants to merge 1 commit into
Open
Conversation
LucaCappelletti94
marked this pull request as ready for review
August 31, 2026 13:28
| #[test] | ||
| fn reject_merge_do_without_nothing() { | ||
| assert_eq!( | ||
| pg().parse_sql_statements( |
Contributor
There was a problem hiding this comment.
The change isn't dialect gated so probably needs to be tested with pg_and_generic()?
Contributor
Author
There was a problem hiding this comment.
RIght, done
| ]) { | ||
| Some(Keyword::DO) => { | ||
| let do_token = self.get_current_token().clone(); | ||
| self.expect_keyword_is(Keyword::NOTHING)?; |
Contributor
There was a problem hiding this comment.
NIT: Could shorten to let nothing_token = self.expect_keyword(Keyword::NOTHING)?;
LucaCappelletti94
force-pushed
the
pg-merge-do-nothing
branch
from
August 31, 2026 16:21
3ea60d3 to
bba2d2d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MERGE ... WHEN MATCHED THEN DO NOTHINGcurrently fails because merge action parsing only recognizesUPDATE,DELETE, andINSERT.DO NOTHINGhas no payload, so it is represented asMergeAction::DoNothingwhile retaining both keyword spans.