Conversation
17 of 21 tasks
14 tasks done
…nger fall back from IRSA
…n the 1.1.0 release notes
…ease notes Their backports merged into branch-1.1, so 1.1.0 won't ship them: apache#6423 (apache#6489), apache#6426 (apache#6486), apache#5507 (apache#6487), apache#6505 (apache#6511), apache#6334 (apache#6491) and apache#6466 (apache#6488). The intro now says that apache#6402 also lists the regressions fixed before the release.
….1.0 release notes
…1.1 now fixes apache#6425 is fixed on branch-1.1 by apache#6554 and apache#6506 by apache#6540, so 1.1.0 won't ship them.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
None. It comes out of the 1.1.0 regression audit (#6399), and the regressions it lists are tracked in #6402.
Rationale for this change
Comet publishes a change log for each release, but no release notes. The upgrade guide already says that correctness fixes "appear in the release notes", and the audit of 1.1.0 found regressions that users should know about before they upgrade, along with the settings that avoid them.
What changes are included in this PR?
docs/source/release-notes/, with an index page and a page for 1.1.0. It sits before the change log in the site navigation.1.1.0 will be released from an rc2 cut from
branch-1.1, which has the fixes for #6424 and #6464 (#6449), #6423 (#6489), #6426 (#6486), #5507 (#6487), #6505 (#6511), #6334 (#6491), #6466 (#6488), #6506 (#6540) and #6425 (#6554), so those aren't listed. #6543 fixes #6504 and #6546 onmain, and if its backport merges before rc2, those two entries come out as well. #6546 turned up after the audit, while fixing #6504.The bug counts come from the audit's data. rc1 has 131
fix:pull requests. 91 of them fix bugs that shipped in 1.0.0, and about 40 of those 91 fixed results that differed from Spark.How are these changes tested?
Each workaround was run against its regression's reproducer on a 1.1.0-rc1 build. Without the setting the reproducer still differs from Spark, and with it the result matches Spark. The Iceberg entries were checked with Iceberg 1.11.0.
Prettier passes on the changed files. I couldn't build the Sphinx site locally, and the docs job only runs on pushes to
main, so the new section hasn't been rendered yet.