Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -164,7 +164,8 @@ public double correlation(final double[] xArray, final double[] yArray)
@SuppressWarnings("unchecked")
Pair<Double, Double>[] pairs = new Pair[n];
for (int i = 0; i < n; i++) {
pairs[i] = new Pair<>(xArray[i], yArray[i]);
// Adding 0.0 maps -0.0 to 0.0 so that signed zeros are counted as ties
pairs[i] = new Pair<>(xArray[i] + 0.0, yArray[i] + 0.0);
}

Arrays.sort(pairs, new Comparator<Pair<Double, Double>>() {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -216,6 +216,16 @@ public void testTwoElements() {
Assert.assertEquals(-1.0, correlation.correlation(xArray, yArray), Double.MIN_VALUE);
}

@Test
public void testSignedZeroTies() {
// -0.0 and 0.0 are the same value and must be counted as a tie
final double[] xArray = new double[] {0.0, -0.0, 1.0};
final double[] yArray = new double[] {1.0, 2.0, 3.0};
Assert.assertEquals(2 / Math.sqrt(6), correlation.correlation(xArray, yArray), 1e-15);
Assert.assertEquals(2 / Math.sqrt(6), correlation.correlation(yArray, xArray), 1e-15);
Assert.assertEquals(Double.NaN, correlation.correlation(new double[] {0.0, -0.0}, new double[] {1.0, 2.0}), 0);
}

@Test
public void test2dDoubleArray() {
final double[][] input = new double[][] {
Expand Down