Repository navigation
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #356 +/- ##
============================================
+ Coverage 86.54% 87.22% +0.67%
+ Complexity 9787 91 -9696
============================================
Files 532 499 -33
Lines 35516 33545 -1971
Branches 6194 5858 -336
============================================
- Hits 30738 29260 -1478
+ Misses 3518 3163 -355
+ Partials 1260 1122 -138 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MathArrays.checkOrder compares with operators that are all false for NaN, so a NaN element is accepted and also skips the next comparison, letting {1, NaN, 0} pass as strictly increasing while StepFunction, PolynomialSplineFunction and the interpolators go on to binary-search unsorted abscissae; any comparison involving NaN is now treated as out of order, covered by testCheckOrderNaN which fails on master.