Skip to content

reject NaN in MathArrays.checkOrder - #356

Open
insaf021 wants to merge 1 commit into
apache:masterfrom
insaf021:matharrays-checkorder-nan
Open

insaf021 wants to merge 1 commit into
apache:masterfrom
insaf021:matharrays-checkorder-nan

Conversation

@insaf021

Copy link
Copy Markdown
Contributor

MathArrays.checkOrder compares with operators that are all false for NaN, so a NaN element is accepted and also skips the next comparison, letting {1, NaN, 0} pass as strictly increasing while StepFunction, PolynomialSplineFunction and the interpolators go on to binary-search unsorted abscissae; any comparison involving NaN is now treated as out of order, covered by testCheckOrderNaN which fails on master.

@codecov-commenter

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 87.22%. Comparing base (f554608) to head (572e179).
⚠️ Report is 420 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master     #356      +/-   ##
============================================
+ Coverage     86.54%   87.22%   +0.67%     
+ Complexity     9787       91    -9696     
============================================
  Files           532      499      -33     
  Lines         35516    33545    -1971     
  Branches       6194     5858     -336     
============================================
- Hits          30738    29260    -1478     
+ Misses         3518     3163     -355     
+ Partials       1260     1122     -138     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants