[LANG-1828] Fix OOM in StringUtils.leftPad/rightPad when size is Integer.MIN_VALUE#1736
Closed
dhruvaggarwal2000 wants to merge 1 commit into
Closed
Conversation
b95effb to
c89da12
Compare
…_VALUE size of pad
c89da12 to
09745ce
Compare
garydgregory
added a commit
that referenced
this pull request
Jun 29, 2026
Integer.MIN_VALUE (#1736).
Member
|
@dhruvaggarwal2000 |
Contributor
Author
|
Got it — trimmed the description. Noted for future PRs |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This issue is tracked as LANG-1828.
Repro:
size - str.length()underflows whensize = Integer.MIN_VALUE, bypassing thepads <= 0early return and causing an OOM allocation.Fix: Short-circuiting on
size <= str.length()before the subtraction — no behavior change for any valid input.Methods affected:
Compatibility report (
mvn package japicmp:cmpagainst 3.20.0)org.apache.commons.lang3.StringUtilspublicStringUtilsObject]Before you push a pull request, review this list: