Handle supplementary code points in StringUtils.splitByCharacterType()#1734
Merged
garydgregory merged 1 commit intoJun 28, 2026
Merged
Conversation
garydgregory
added a commit
that referenced
this pull request
Jun 28, 2026
garydgregory
added a commit
that referenced
this pull request
Jun 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Repro:
splitByCharacterType("A" + boldA), whereboldAis U+1D400 MATHEMATICAL BOLD CAPITAL A.Expected:
["A𝐀"], one token, sinceAand the boldAare both upper-case letters.Actual:
["A", "𝐀"].Cause: the shared worker iterates one
charat a time and callsCharacter.getType(char), so each half of a surrogate pair reads asSURROGATErather than the real category of the code point. Same-type neighbours get split, and in thecamelCasepathpos - 1lands inside the pair.splitByCharacterType("5" + boldFive)splits two decimal digits the same way.Fix: iterate by code point with
Character.codePointAt/charCountand classify the whole code point; thecamelCaseboundary backs up byCharacter.charCount(Character.codePointBefore(...)). BMP input is unchanged.