Repository navigation
Conversation
getConstantPoolEntry and getValue resolve a bytecode reference operand into a constant pool entry but only reject negative indices, so an operand pointing past the pool made CpBands.cpUTF8Value and its siblings read the backing array out of bounds and throw ArrayIndexOutOfBoundsException out of the declared Pack200Exception contract. Both resolvers now report the bad index as a Pack200Exception.
Contributor
Author
|
any update? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Out-of-range constant pool index in the pack200 unpacker
SegmentConstantPool.getConstantPoolEntryandgetValueresolve a bytecode reference operand into a constant pool entry but only reject negative indices (viatoIndex), then hand the value straight toCpBands.cpUTF8Value/cpClassValue/cpMethodValue/ ..., each of which reads its backing array with no upper bound. A crafted archive whose operand points past the pool makes those accessors throwArrayIndexOutOfBoundsExceptionout ofsetByteCodeOperands, escaping the declaredPack200Exceptioncontract ofArchive.unpack. Both resolvers now report the out-of-range index as aPack200Exception, matching how the negative case is already handled. This is distinct from #788 (which boundsBandSet.getReferences, the constant-pool structure resolver) and #805 (negative operands): the gap here is the too-large index on the bytecode-operand path.mvn; that'smvnon the command line by itself.