Repository navigation
Conversation
A forward or backward call whose index exceeds the surrounding callables left Call.callable null and NPEd later in readBands; reject it with a Pack200Exception so a crafted archive stays within the declared IOException contract.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Unchecked NullPointerException from an unresolvable attribute layout call
When a custom attribute layout contains a
callwhose index points past the available callables (for example[(1)], a lone callable whose body forward-calls a non-existent callable),NewAttributeBands.resolveCallsForElementleaves theCall's callable unset.Call.readBandslater dereferences it throughcallable.addCount(count), soparseAttributesthrows a rawNullPointerExceptioneven though it only declaresIOException/Pack200Exception, and the unchecked exception escapes thePack200CompressorInputStreamconstructor and theArchive/Segmentunpack entry points. The call is now rejected with aPack200Exceptionat resolution time; layouts whose calls resolve are unchanged.mvn; that'smvnon the command line by itself.