Repository navigation
Conversation
| package org.apache.commons.compress.archivers.arj; | ||
|
|
||
| /** | ||
| * Circular byte buffer. Copied from org.apache.commons.compress.archivers.lha.CircularBuffer and modified for ARJ. |
There was a problem hiding this comment.
@IgorZolin
Modified how? Can we reduce the copy pasta and have a shared implementation?
There was a problem hiding this comment.
Sorry, it was not really modified, just don't want to change someones code. I could make lha.CircularBuffer public and reuse it (there would be some risk that changes in lha could broke arj).
There was a problem hiding this comment.
That's what unit tests are for ;)
There was a problem hiding this comment.
You didn't follow the template instructions, so the build is broken...
There was a problem hiding this comment.
You didn't follow the template instructions, so the build is broken...
sorry, i've fix lint promlems, can we run build?
|
Hi @IgorZolin Thanks for improving ARJ decompression support. Please take a look at my PR 812 which replaces the |
|
ok, i can pause my pr and update it after yours pr would be merged? |
Thanks for your contribution to Apache Commons! Your help is appreciated!
Before you push a pull request, review this list:
mvn; that'smvnon the command line by itself.Add arj archives decompression.