[COLLECTIONS-891] Fix IndexedCollection contains equality#687
Draft
OldTruckDriver wants to merge 2 commits into
Draft
[COLLECTIONS-891] Fix IndexedCollection contains equality#687OldTruckDriver wants to merge 2 commits into
OldTruckDriver wants to merge 2 commits into
Conversation
contains(Object) returned index.containsKey(transform(object)), so it reported true whenever any element shared the transformed key, breaking Collection.contains for a non-injective transformer. Look up the key's bucket and check actual object equality within it. Add tests for unique and non-unique indexes. Reviewed-by: OpenAI Codex Reviewed-by: Anthropic Claude Code
Member
|
I've converted this PR to a Draft PR until we resolve the discussing in COLLECTIONS-891. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[COLLECTIONS-891] Fix IndexedCollection contains equality
IndexedCollection#contains(Object) used the transformed key only, so it could return true for an object that was never added when another object mapped to the same key.
This change keeps the indexed lookup as a fast candidate filter, then checks object equality within the indexed values before returning true.
Tests cover both unique and non-unique indexed collections where "01" and "1" map to the same key but are not equal objects.
Tests run: