Skip to content

pre-commit: enable markdownlint rule MD012#9364

Merged
DaanHoogland merged 2 commits into
apache:mainfrom
jbampton:enable-markdownlint-rule-MD012
Dec 27, 2024
Merged

pre-commit: enable markdownlint rule MD012#9364
DaanHoogland merged 2 commits into
apache:mainfrom
jbampton:enable-markdownlint-rule-MD012

Conversation

@jbampton

Copy link
Copy Markdown
Member

MD012 no-multiple-blanks - Multiple consecutive blank lines

https://github.com/DavidAnson/markdownlint/blob/main/doc/md012.md

Description

This PR cleans up and standardizes the Markdown files.

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • build/CI
  • test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

Ran locally:

pre-commit run --all-files

How did you try to break this feature and the system with this change?

@codecov

codecov Bot commented Jul 10, 2024

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 16.06%. Comparing base (631bba2) to head (06d67eb).
Report is 1 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #9364      +/-   ##
============================================
- Coverage     16.06%   16.06%   -0.01%     
+ Complexity    12872    12871       -1     
============================================
  Files          5642     5642              
  Lines        493973   493973              
  Branches      59895    59895              
============================================
- Hits          79351    79350       -1     
- Misses       405837   405838       +1     
  Partials       8785     8785              
Flag Coverage Δ
uitests 4.01% <ø> (ø)
unittests 16.90% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jbampton
jbampton marked this pull request as draft October 14, 2024 11:33
@jbampton
jbampton force-pushed the enable-markdownlint-rule-MD012 branch from 1525c7a to 99a50a8 Compare October 14, 2024 11:39
@jbampton
jbampton marked this pull request as ready for review October 14, 2024 11:40
@jbampton

Copy link
Copy Markdown
Member Author

@blueorangutan package

@blueorangutan

Copy link
Copy Markdown

@jbampton a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@blueorangutan

Copy link
Copy Markdown

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 11336

@DaanHoogland DaanHoogland left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clgtm

@vishesh92 vishesh92 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clgtm

@DaanHoogland
DaanHoogland force-pushed the enable-markdownlint-rule-MD012 branch from 99a50a8 to dec53d0 Compare October 23, 2024 19:18
@DaanHoogland DaanHoogland added this to the 4.21.0.0 milestone Oct 24, 2024
@jbampton
jbampton force-pushed the enable-markdownlint-rule-MD012 branch from dec53d0 to 4b440ae Compare December 20, 2024 21:03
@jbampton

Copy link
Copy Markdown
Member Author

@blueorangutan package

@blueorangutan

Copy link
Copy Markdown

@jbampton a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@blueorangutan

Copy link
Copy Markdown

Packaging result [SF]: ✖️ el8 ✖️ el9 ✖️ debian ✖️ suse15. SL-JID 11868

@jbampton

Copy link
Copy Markdown
Member Author

@blueorangutan package

@blueorangutan

Copy link
Copy Markdown

@jbampton a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@blueorangutan

Copy link
Copy Markdown

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 11902

@DaanHoogland
DaanHoogland merged commit 6a2c7b0 into apache:main Dec 27, 2024
@jbampton
jbampton deleted the enable-markdownlint-rule-MD012 branch December 28, 2024 05:49
dhslove pushed a commit to ablecloud-team/ablestack-cloud that referenced this pull request Jan 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

No open projects
Status: Done

Development

Successfully merging this pull request may close these issues.

5 participants