ui: improve sort utility for metrics#9247
Merged
Merged
Conversation
This improves the UI sorting utility to check for metrics data and sort after cleaning the string data. Fixes apache#8663 Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
yadvr
requested review from
DaanHoogland,
shwstppr,
sureshanaparti and
vishesh92
June 13, 2024 12:26
yadvr
commented
Jun 13, 2024
|
|
||
| function stringComparator (a, b) { | ||
| return a.toString().localeCompare(b.toString()) | ||
| return a.toString().localeCompare(b.toString(), undefined, { numeric: true }) |
Member
Author
There was a problem hiding this comment.
FYI - this would also consider for cases where there is numeric string data
Member
Author
|
@rohityadavcloud a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 4.19 #9247 +/- ##
============================================
- Coverage 14.96% 14.96% -0.01%
+ Complexity 11015 11014 -1
============================================
Files 5377 5378 +1
Lines 469605 469812 +207
Branches 60258 58818 -1440
============================================
- Hits 70296 70290 -6
- Misses 391523 391735 +212
- Partials 7786 7787 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
UI build: ✔️ |
DaanHoogland
approved these changes
Jun 13, 2024
DaanHoogland
left a comment
DaanHoogland
left a comment
Contributor
There was a problem hiding this comment.
clgtm, tests ok in qa
dhslove
pushed a commit
to ablecloud-team/ablestack-cloud
that referenced
this pull request
Jun 17, 2024
This improves the UI sorting utility to check for metrics data and sort after cleaning the string data. Fixes apache#8663 Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This improves the UI sorting utility to check for metrics data and sort after cleaning the string data.
Fixes #8663
Types of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
Bug Severity