ui: fix dashboard retrievals based on permissions#9237
Merged
Conversation
Fixes apache#9233 Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
Member
|
@rohityadavcloud a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 4.19 #9237 +/- ##
============================================
- Coverage 14.96% 14.96% -0.01%
+ Complexity 11013 11012 -1
============================================
Files 5377 5377
Lines 469567 469603 +36
Branches 60162 59962 -200
============================================
- Hits 70285 70279 -6
- Misses 391498 391541 +43
+ Partials 7784 7783 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
UI build: ✔️ |
DaanHoogland
approved these changes
Jun 13, 2024
DaanHoogland
left a comment
DaanHoogland
left a comment
Contributor
There was a problem hiding this comment.
clgtm and tested with some list APIs revoked:
dhslove
pushed a commit
to ablecloud-team/ablestack-cloud
that referenced
this pull request
Jun 17, 2024
Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #9233
Retrieves and shows dashboard details if they are allowed
Types of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
Bug Severity
Screenshots (if appropriate):
How Has This Been Tested?
Created a role with some permissions denied (listKubernetesClusters, listVPCs, listEvents)
Created an account with the role
Logged in with new account to observe elements for above APIs are not shown
Created another account with a role which has permissions for above APIs
Logged in with the account to observe all UI elements are shown
How did you try to break this feature and the system with this change?