Skip to content

vxlan: do not create duplicated network for private gateway#9232

Merged
borisstoyanov merged 1 commit into
apache:4.19from
weizhouapache:4.19-fix-duplicated-network-for-vxlan-private-gateway
Jun 19, 2024
Merged

vxlan: do not create duplicated network for private gateway#9232
borisstoyanov merged 1 commit into
apache:4.19from
weizhouapache:4.19-fix-duplicated-network-for-vxlan-private-gateway

Conversation

@weizhouapache

@weizhouapache weizhouapache commented Jun 12, 2024

Copy link
Copy Markdown
Member

Description

This PR fixes #7891

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • build/CI

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

@weizhouapache

Copy link
Copy Markdown
Member Author

@blueorangutan package

@blueorangutan

Copy link
Copy Markdown

@weizhouapache a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@codecov

codecov Bot commented Jun 12, 2024

Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 14.96%. Comparing base (1577218) to head (0ecf105).
Report is 9 commits behind head on 4.19.

Files Patch % Lines
.../com/cloud/network/guru/VxlanGuestNetworkGuru.java 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               4.19    #9232      +/-   ##
============================================
- Coverage     14.96%   14.96%   -0.01%     
- Complexity    11002    11003       +1     
============================================
  Files          5373     5377       +4     
  Lines        469315   469465     +150     
  Branches      59847    61125    +1278     
============================================
+ Hits          70233    70247      +14     
- Misses       391309   391440     +131     
- Partials       7773     7778       +5     
Flag Coverage Δ
uitests 4.30% <ø> (ø)
unittests 15.67% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@blueorangutan

Copy link
Copy Markdown

Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 9895

@weizhouapache

Copy link
Copy Markdown
Member Author

@blueorangutan test rocky8 kvm-rocky8

@blueorangutan

Copy link
Copy Markdown

@weizhouapache a [SL] Trillian-Jenkins test job (rocky8 mgmt + kvm-rocky8) has been kicked to run smoke tests

@blueorangutan

Copy link
Copy Markdown

[SF] Trillian test result (tid-10423)
Environment: kvm-rocky8 (x2), Advanced Networking with Mgmt server r8
Total time taken: 44939 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr9232-t10423-kvm-rocky8.zip
Smoke tests completed. 131 look OK, 0 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test Result Time (s) Test File

@DaanHoogland DaanHoogland left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clgtm

@borisstoyanov borisstoyanov left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, checked it manually

@borisstoyanov borisstoyanov removed their assignment Jun 19, 2024
@borisstoyanov
borisstoyanov merged commit 227c156 into apache:4.19 Jun 19, 2024
@DaanHoogland
DaanHoogland deleted the 4.19-fix-duplicated-network-for-vxlan-private-gateway branch June 19, 2024 06:45
dhslove pushed a commit to ablecloud-team/ablestack-cloud that referenced this pull request Jun 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

No open projects
Status: Done

Development

Successfully merging this pull request may close these issues.

The corresponding Network Tier like vpc-XXX-privateNetwork cannot be automatically removed

5 participants