test: additional check to ensure hosts are left in up state by shwstppr · Pull Request #8383 · apache/cloudstack

shwstppr · 2023-12-20T11:18:19Z

Description

With this change, a fix is added for failures seen with test_08_migrate_vm or other migration-related tests because the target host is in Connecting state,
#8356 (comment)
#8374 (comment)
and more

Types of changes

Breaking change (fix or feature that would cause existing functionality to change)
New feature (non-breaking change which adds functionality)
Bug fix (non-breaking change which fixes an issue)
Enhancement (improves an existing feature and functionality)
Cleanup (Code refactoring and cleanup, that may add test cases)
build/CI

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

Major
Minor

Bug Severity

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>

codecov · 2023-12-20T12:23:49Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (64ecd00) 13.12% compared to head (b4c74d3) 13.12%.
Report is 2 commits behind head on 4.18.

Additional details and impacted files

@@            Coverage Diff            @@
##               4.18    #8383   +/-   ##
=========================================
  Coverage     13.12%   13.12%           
  Complexity     9141     9141           
=========================================
  Files          2720     2720           
  Lines        257723   257723           
  Branches      40177    40177           
=========================================
  Hits          33838    33838           
  Misses       219595   219595           
  Partials       4290     4290

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

weizhouapache · 2023-12-20T13:26:47Z

+                        hostid=host.id,
+                        type='Routing'
+                    )[0]
+                    if restarted_host.state == state:


should == state be == "Up" ?

@weizhouapache yes 🙈
But I'm not able to reproduce the issue with hosts remaining in Connecting state so not sure if this will solve the problem

shwstppr · 2023-12-20T13:36:35Z

@blueorangutan package

blueorangutan · 2023-12-20T13:38:04Z

@shwstppr a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

shwstppr · 2023-12-20T16:51:48Z

@blueorangutan package

blueorangutan · 2023-12-20T16:56:04Z

@shwstppr a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2023-12-20T17:58:10Z

Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 8106

weizhouapache · 2023-12-20T18:04:34Z

@blueorangutan test

blueorangutan · 2023-12-20T18:06:03Z

@weizhouapache a [SL] Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

blueorangutan · 2023-12-21T05:49:14Z

[SF] Trillian test result (tid-8648)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 40634 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr8383-t8648-kvm-centos7.zip
Smoke tests completed. 109 look OK, 0 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File

weizhouapache

code lgtm

@shwstppr
smoke test results look perfect. is it ready for review ?

shwstppr · 2023-12-21T08:00:10Z

@weizhouapache there seems some issue with GH action run on test cleanup. Checking that

DaanHoogland

lgtm, note that this test is not safe in life environment to begin with, so this does not have an influence to its

weizhouapache · 2023-12-21T08:12:57Z

@weizhouapache there seems some issue with GH action run on test cleanup. Checking that

@shwstppr right..
so we should consider "Unsecure" as a valid and good state for kvm hosts.
(ignore this, the state of Unsecure hosts is also Up...)

Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>

shwstppr · 2023-12-21T09:07:11Z

@weizhouapache I guess Unsecure is just shown in UI and we don't have such a state in API. In API it returns host.details.secured flag. GH action error was related to the zone variable missing. Fixed it.

With this change, I'm testing a fix for failures seen with test_08_migrate_vm or other migration-related test because the target host is in Connecting state,
#8356 (comment)
#8374 (comment)
and more

weizhouapache · 2023-12-21T09:12:20Z

@weizhouapache I guess Unsecure is just shown in UI and we don't have such a state in API. In API it returns host.details.secured flag.

yes, right.

GH action error was related to the zone variable missing. Fixed it.

With this change, I'm testing a fix for failures seen with test_08_migrate_vm or other migration-related test because the target host is in Connecting state, #8356 (comment) #8374 (comment) and more

Great !

shwstppr · 2023-12-21T12:39:34Z

Will merge this once GH actions return success

) With this change, a fix is added for failures seen with test_08_migrate_vm or other migration-related tests because the target host is in `Connecting` state, apache#8356 (comment) apache#8374 (comment) and more

boring-cyborg Bot added component:integration-test Python Warning... Python code Ahead! labels Dec 20, 2023

test: additional check to ensure hosts are left in up state

1951b0c

Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>

shwstppr force-pushed the test-addcheck-vmlifecycle branch from b84b654 to 1951b0c Compare December 20, 2023 11:20

weizhouapache reviewed Dec 20, 2023

View reviewed changes

shwstppr commented Dec 20, 2023

View reviewed changes

Comment thread test/integration/smoke/test_vm_life_cycle.py Outdated

Update test/integration/smoke/test_vm_life_cycle.py

29b05e4

shwstppr commented Dec 20, 2023

View reviewed changes

Comment thread test/integration/smoke/test_vm_life_cycle.py Outdated

Update test/integration/smoke/test_vm_life_cycle.py

fdf2af3

weizhouapache approved these changes Dec 21, 2023

View reviewed changes

DaanHoogland approved these changes Dec 21, 2023

View reviewed changes

fix non-kvm

b4c74d3

Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>

shwstppr closed this Dec 21, 2023

shwstppr reopened this Dec 21, 2023

shwstppr marked this pull request as ready for review December 21, 2023 12:39

shwstppr merged commit d83d994 into apache:4.18 Dec 21, 2023

shwstppr deleted the test-addcheck-vmlifecycle branch December 21, 2023 15:26

DaanHoogland added this to the 4.18.3 milestone Sep 6, 2024

Uh oh!

Conversation

shwstppr commented Dec 20, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Types of changes

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

Bug Severity

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

Uh oh!

codecov Bot commented Dec 20, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

weizhouapache Dec 20, 2023

Choose a reason for hiding this comment

Uh oh!

shwstppr Dec 20, 2023

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

shwstppr commented Dec 20, 2023

Uh oh!

blueorangutan commented Dec 20, 2023

Uh oh!

shwstppr commented Dec 20, 2023

Uh oh!

blueorangutan commented Dec 20, 2023

Uh oh!

blueorangutan commented Dec 20, 2023

Uh oh!

weizhouapache commented Dec 20, 2023

Uh oh!

blueorangutan commented Dec 20, 2023

Uh oh!

blueorangutan commented Dec 21, 2023

Uh oh!

weizhouapache left a comment

Choose a reason for hiding this comment

Uh oh!

shwstppr commented Dec 21, 2023

Uh oh!

DaanHoogland left a comment

Choose a reason for hiding this comment

Uh oh!

weizhouapache commented Dec 21, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

shwstppr commented Dec 21, 2023

Uh oh!

weizhouapache commented Dec 21, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

shwstppr commented Dec 21, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

shwstppr commented Dec 20, 2023 •

edited

Loading

codecov Bot commented Dec 20, 2023 •

edited

Loading

weizhouapache commented Dec 21, 2023 •

edited

Loading

weizhouapache commented Dec 21, 2023 •

edited

Loading