Skip to content

Fixed spelling and added missing states to response#8248

Merged
DaanHoogland merged 1 commit into
apache:4.18from
OlegChuev:fix/ip-addresses-state-spelling-fix
Nov 18, 2023
Merged

Fixed spelling and added missing states to response#8248
DaanHoogland merged 1 commit into
apache:4.18from
OlegChuev:fix/ip-addresses-state-spelling-fix

Conversation

@OlegChuev

@OlegChuev OlegChuev commented Nov 17, 2023

Copy link
Copy Markdown
Contributor

Description

This PR just fixes spelling and adding missing states to responses

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • build/CI

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

@boring-cyborg

boring-cyborg Bot commented Nov 17, 2023

Copy link
Copy Markdown

Congratulations on your first Pull Request and welcome to the Apache CloudStack community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/cloudstack/blob/main/CONTRIBUTING.md)
Here are some useful points:

@codecov

codecov Bot commented Nov 17, 2023

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (88ff77d) 12.93% compared to head (16ac286) 13.10%.
Report is 213 commits behind head on 4.18.

Additional details and impacted files
@@             Coverage Diff              @@
##               4.18    #8248      +/-   ##
============================================
+ Coverage     12.93%   13.10%   +0.16%     
- Complexity     8944     9122     +178     
============================================
  Files          2715     2720       +5     
  Lines        256107   257638    +1531     
  Branches      39938    40168     +230     
============================================
+ Hits          33139    33753     +614     
- Misses       218808   219619     +811     
- Partials       4160     4266     +106     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@DaanHoogland DaanHoogland left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

text lgtm

@DaanHoogland

Copy link
Copy Markdown
Contributor

@shwstppr @weizhouapache I think we can merge this.

@shwstppr shwstppr left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@DaanHoogland
DaanHoogland merged commit 1b56a8e into apache:4.18 Nov 18, 2023
@boring-cyborg

boring-cyborg Bot commented Nov 18, 2023

Copy link
Copy Markdown

Awesome work, congrats on your first merged pull request!

DaanHoogland added a commit that referenced this pull request Nov 18, 2023
* 4.18:
  Fixed spelling and added missing states to response (#8248)
  Let Prometheus exporter plugin support utf8 characters (#8228)
dhslove pushed a commit to ablecloud-team/ablestack-cloud that referenced this pull request Nov 29, 2023
dhslove pushed a commit to ablecloud-team/ablestack-cloud that referenced this pull request Nov 29, 2023
* 4.18:
  Fixed spelling and added missing states to response (apache#8248)
  Let Prometheus exporter plugin support utf8 characters (apache#8228)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants