Fixed spelling and added missing states to response#8248
Merged
DaanHoogland merged 1 commit intoNov 18, 2023
Conversation
|
Congratulations on your first Pull Request and welcome to the Apache CloudStack community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/cloudstack/blob/main/CONTRIBUTING.md)
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 4.18 #8248 +/- ##
============================================
+ Coverage 12.93% 13.10% +0.16%
- Complexity 8944 9122 +178
============================================
Files 2715 2720 +5
Lines 256107 257638 +1531
Branches 39938 40168 +230
============================================
+ Hits 33139 33753 +614
- Misses 218808 219619 +811
- Partials 4160 4266 +106 ☔ View full report in Codecov by Sentry. |
Contributor
|
@shwstppr @weizhouapache I think we can merge this. |
|
Awesome work, congrats on your first merged pull request! |
dhslove
pushed a commit
to ablecloud-team/ablestack-cloud
that referenced
this pull request
Nov 29, 2023
dhslove
pushed a commit
to ablecloud-team/ablestack-cloud
that referenced
this pull request
Nov 29, 2023
* 4.18: Fixed spelling and added missing states to response (apache#8248) Let Prometheus exporter plugin support utf8 characters (apache#8228)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR just fixes spelling and adding missing states to responses
Types of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
Bug Severity
Screenshots (if appropriate):
How Has This Been Tested?
How did you try to break this feature and the system with this change?