Skip to content

ui: Admin, account and project dashboard improvements#8193

Merged
DaanHoogland merged 1 commit into
apache:4.18from
shapeblue:418-ui-dashboard
Nov 8, 2023
Merged

ui: Admin, account and project dashboard improvements#8193
DaanHoogland merged 1 commit into
apache:4.18from
shapeblue:418-ui-dashboard

Conversation

@yadvr

@yadvr yadvr commented Nov 7, 2023

Copy link
Copy Markdown
Member

This backports only the dashboard changes from
#7956 and 5d9ae31

This backports only the dashboard changes from
apache#7956 and
5d9ae31

Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
@yadvr

yadvr commented Nov 7, 2023

Copy link
Copy Markdown
Member Author

Have been missing the dashboard on 4.18 - backported it from main branch 1:1 changes esp only the CapacityDashboard.vue and UsageDashboard.vue changes and no changes in config.json etc.

@blueorangutan ui

@blueorangutan

Copy link
Copy Markdown

@rohityadavcloud a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

@DaanHoogland

Copy link
Copy Markdown
Contributor

@rohityadavcloud looks fine but are we going to release a 4.18 maintenance release with this improvement? seems like it is only going to end up in 4.19 anyway.

@blueorangutan

Copy link
Copy Markdown

UI build: ✔️
Live QA URL: https://qa.cloudstack.cloud/simulator/pr/8193 (QA-JID-225)

@yadvr

yadvr commented Nov 7, 2023

Copy link
Copy Markdown
Member Author

@DaanHoogland the changes are already in main/4.19 - #7956 - since the changes are only in the UI - could benefit the community for if/when we do a 4.18.2.0 release. If you think it's probably not that useful I'm happy to close this (as I built a 4.18-based UI using this for my own benefit in my ACS homelab).

@codecov

codecov Bot commented Nov 7, 2023

Copy link
Copy Markdown

Codecov Report

Merging #8193 (3376f94) into 4.18 (e6f048b) will increase coverage by 0.02%.
Report is 1 commits behind head on 4.18.
The diff coverage is n/a.

@@             Coverage Diff              @@
##               4.18    #8193      +/-   ##
============================================
+ Coverage     13.07%   13.09%   +0.02%     
- Complexity     9111     9122      +11     
============================================
  Files          2720     2720              
  Lines        257597   257603       +6     
  Branches      40160    40160              
============================================
+ Hits          33680    33740      +60     
+ Misses       219682   219598      -84     
- Partials       4235     4265      +30     

see 8 files with indirect coverage changes

📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today!

@DaanHoogland

Copy link
Copy Markdown
Contributor

I don't object in any way, @rohityadavcloud . If it is convenient for you to merge, let's do it.

@yadvr

yadvr commented Nov 8, 2023

Copy link
Copy Markdown
Member Author

Thanks Daan - I could still use two LGTMs cc @shwstppr @harikrishna-patnala @DaanHoogland

@shwstppr shwstppr left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Checked on QA server

Screenshot from 2023-11-08 14-36-00

Screenshot from 2023-11-08 14-37-39

@DaanHoogland DaanHoogland left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clgtm

@DaanHoogland
DaanHoogland merged commit b2e8327 into apache:4.18 Nov 8, 2023
@DaanHoogland
DaanHoogland deleted the 418-ui-dashboard branch November 8, 2023 09:08
dhslove pushed a commit to ablecloud-team/ablestack-cloud that referenced this pull request Nov 16, 2023
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants