Skip to content

CKS: fix wrong format of cluster size on UI#8182

Merged
DaanHoogland merged 1 commit into
apache:4.18from
weizhouapache:4.18-ui-fix-cks-size
Nov 3, 2023
Merged

CKS: fix wrong format of cluster size on UI#8182
DaanHoogland merged 1 commit into
apache:4.18from
weizhouapache:4.18-ui-fix-cks-size

Conversation

@weizhouapache

Copy link
Copy Markdown
Member

Description

This PR fixes the UI bug with CKS cluster size

Prior to this PR
image

With this PR
image

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • build/CI

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

@weizhouapache

Copy link
Copy Markdown
Member Author

@blueorangutan ui

@blueorangutan

Copy link
Copy Markdown

@weizhouapache a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

@shwstppr shwstppr left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov

codecov Bot commented Nov 2, 2023

Copy link
Copy Markdown

Codecov Report

Merging #8182 (a46ddf1) into 4.18 (3b11663) will increase coverage by 0.00%.
The diff coverage is n/a.

@@            Coverage Diff            @@
##               4.18    #8182   +/-   ##
=========================================
  Coverage     13.06%   13.07%           
  Complexity     9111     9111           
=========================================
  Files          2720     2720           
  Lines        257592   257592           
  Branches      40158    40158           
=========================================
+ Hits          33663    33679   +16     
+ Misses       219698   219680   -18     
- Partials       4231     4233    +2     

see 3 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@DaanHoogland DaanHoogland left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clgtm

@DaanHoogland

Copy link
Copy Markdown
Contributor

@blueorangutan ui

@blueorangutan

Copy link
Copy Markdown

@DaanHoogland a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

@blueorangutan

Copy link
Copy Markdown

UI build: ✔️
Live QA URL: https://qa.cloudstack.cloud/simulator/pr/8182 (QA-JID-220)

@DaanHoogland

Copy link
Copy Markdown
Contributor

verified in qa

@DaanHoogland DaanHoogland added this to the 4.18.2.0 milestone Nov 3, 2023
@DaanHoogland
DaanHoogland merged commit e6f048b into apache:4.18 Nov 3, 2023
@DaanHoogland
DaanHoogland deleted the 4.18-ui-fix-cks-size branch November 3, 2023 09:01
dhslove pushed a commit to ablecloud-team/ablestack-cloud that referenced this pull request Nov 8, 2023
Dajeong-Park added a commit to Dajeong-Park/ablestack-cloud that referenced this pull request Nov 15, 2023
Dajeong-Park added a commit to Dajeong-Park/ablestack-cloud that referenced this pull request Nov 15, 2023
Dajeong-Park added a commit to Dajeong-Park/ablestack-cloud that referenced this pull request Nov 16, 2023
shwstppr pushed a commit to shapeblue/cloudstack that referenced this pull request Dec 27, 2023
(cherry picked from commit e6f048b)
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants