Skip to content

UI: Add domain and account fields to Register/Upload Template/ISO view#7872

Merged
weizhouapache merged 4 commits into
apache:mainfrom
shapeblue:ui-add-domain-account-to-register-tmpl
Aug 17, 2023
Merged

UI: Add domain and account fields to Register/Upload Template/ISO view#7872
weizhouapache merged 4 commits into
apache:mainfrom
shapeblue:ui-add-domain-account-to-register-tmpl

Conversation

@nvazquez

@nvazquez nvazquez commented Aug 16, 2023

Copy link
Copy Markdown
Contributor

Description

This PR allows passing the optional parameters domainid and account to the registerTemplate/registerISO/uploadISO/uploadTemplate APIs (was only possible to pass these parameters through the API):

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

  • Register a template as an admin to another account in other domain -> verify domainid and account parameters are passed correctly
  • Register a template as an admin without setting any domain or account -> verify domainid and account parameters are not passed
  • Login as a user, verify the domain dropdown is not displayed

@nvazquez nvazquez added this to the 4.19.0.0 milestone Aug 16, 2023
@nvazquez nvazquez changed the title UI add domain account to register tmpl UI: Add domain and account fields to Register Template view Aug 16, 2023
@codecov

codecov Bot commented Aug 16, 2023

Copy link
Copy Markdown

Codecov Report

Merging #7872 (dbb5cc5) into main (8b5ba13) will decrease coverage by 0.01%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##               main    #7872      +/-   ##
============================================
- Coverage     14.38%   14.38%   -0.01%     
  Complexity    10078    10078              
============================================
  Files          2748     2748              
  Lines        258975   258975              
  Branches      40329    40329              
============================================
- Hits          37262    37260       -2     
- Misses       216897   216902       +5     
+ Partials       4816     4813       -3     

see 2 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@shwstppr

Copy link
Copy Markdown
Contributor

@nvazquez should similar fields be added in the ISO form?

@DaanHoogland

Copy link
Copy Markdown
Contributor

@blueorangutan ui

@blueorangutan

Copy link
Copy Markdown

@DaanHoogland a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

@blueorangutan

Copy link
Copy Markdown

UI build: ✔️
Live QA URL: https://qa.cloudstack.cloud/simulator/pr/7872 (QA-JID-147)

@weizhouapache

Copy link
Copy Markdown
Member

@nvazquez should similar fields be added in the ISO form?

make sense
cc @nvazquez

@nvazquez

Copy link
Copy Markdown
Contributor Author

Thanks @shwstppr @weizhouapache - I have added them to the Register/Upload ISO view as well

@nvazquez nvazquez changed the title UI: Add domain and account fields to Register Template view UI: Add domain and account fields to Register/Upload Template/ISO view Aug 16, 2023
@nvazquez

Copy link
Copy Markdown
Contributor Author

@blueorangutan ui

@blueorangutan

Copy link
Copy Markdown

@nvazquez a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

@blueorangutan

Copy link
Copy Markdown

UI build: ✔️
Live QA URL: https://qa.cloudstack.cloud/simulator/pr/7872 (QA-JID-148)

@weizhouapache weizhouapache left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code lgtm

registered a templae for ROOT/user on QA server, looks good
image

@weizhouapache

Copy link
Copy Markdown
Member

@nvazquez
can you fix the conflicts ? thanks

@nvazquez

Copy link
Copy Markdown
Contributor Author

Done thanks @weizhouapache
@blueorangutan ui

@blueorangutan

Copy link
Copy Markdown

@nvazquez a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

@blueorangutan

Copy link
Copy Markdown

UI build: ✔️
Live QA URL: https://qa.cloudstack.cloud/simulator/pr/7872 (QA-JID-149)

@DaanHoogland

Copy link
Copy Markdown
Contributor

@blueorangutan ui

@blueorangutan

Copy link
Copy Markdown

@DaanHoogland a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

@blueorangutan

Copy link
Copy Markdown

UI build: ✔️
Live QA URL: https://qa.cloudstack.cloud/simulator/pr/7872 (QA-JID-150)

@blueorangutan

Copy link
Copy Markdown

Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 6815

@DaanHoogland DaanHoogland left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks and tests ok

@weizhouapache
weizhouapache merged commit 7049a60 into apache:main Aug 17, 2023
@DaanHoogland
DaanHoogland deleted the ui-add-domain-account-to-register-tmpl branch August 18, 2023 07:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants