storpool: fix pom.xml which caused docker image build failures

[weizhouapache]

Description

This PR fixes the issue which can be reproduced by steps below:

• git clone https://github.com/apache/cloudstack.git
• cd cloudstack
• rm -rf .git/
• run mvn -P developer,systemvm clean install

Without this PR, it fails with error

 > [ 8/10] RUN mvn -Pdeveloper -Dsimulator -DskipTests clean install:
668.1 [ERROR] Failed to execute goal pl.project13.maven:git-commit-id-plugin:4.9.10:revision (get-the-git-infos) on project cloud-plugin-storage-volume-storpool: .git directory is not found! Please specify a valid [dotGitDirectory] in your pom.xml -> [Help 1]

Types of changes

• Breaking change (fix or feature that would cause existing functionality to change)
• New feature (non-breaking change which adds functionality)
• Bug fix (non-breaking change which fixes an issue)
• Enhancement (improves an existing feature and functionality)
• Cleanup (Code refactoring and cleanup, that may add test cases)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

• Major
• Minor

Bug Severity

• BLOCKER
• Critical
• Major
• Minor
• Trivial

Screenshots (if appropriate):

How Has This Been Tested?

[weizhouapache]

@blueorangutan package

[blueorangutan]

@weizhouapache a [SF] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

[codecov]

Codecov Report

Merging #7845 (eb18e32) into 4.18 (fdb23da) will not change coverage.
Report is 1 commits behind head on 4.18.
The diff coverage is n/a.

@@            Coverage Diff            @@
##               4.18    #7845   +/-   ##
=========================================
  Coverage     13.02%   13.02%           
  Complexity     9032     9032           
=========================================
  Files          2720     2720           
  Lines        257076   257076           
  Branches      40088    40088           
=========================================
  Hits          33475    33475           
  Misses       219397   219397           
  Partials       4204     4204           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

[blueorangutan]

Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 6737

[DaanHoogland]

change looks sane, but does the docker build need to delete the .git directory @weizhouapache ?

[weizhouapache]

change looks sane, but does the docker build need to delete the .git directory @weizhouapache ?

@DaanHoogland
I have no idea how github action pulls the code, it seems .git directory is missing in the build container.
https://github.com/apache/cloudstack/blob/main/.github/workflows/docker-cloudstack-simulator.yml

[DaanHoogland]

change looks sane, but does the docker build need to delete the .git directory @weizhouapache ?

@DaanHoogland I have no idea how github action pulls the code, it seems .git directory is missing in the build container. https://github.com/apache/cloudstack/blob/main/.github/workflows/docker-cloudstack-simulator.yml

ok, if it is otherwise out of our control let's merge

[slavkap]

LGTM but didn't tested it with docker

[weizhouapache]

change looks sane, but does the docker build need to delete the .git directory @weizhouapache ?

@DaanHoogland I have no idea how github action pulls the code, it seems .git directory is missing in the build container. https://github.com/apache/cloudstack/blob/main/.github/workflows/docker-cloudstack-simulator.yml

ok, if it is otherwise out of our control let's merge

yes.
we could also consider that some users download the source code tarball from cloudstack website, which does not have .git directory as well.

[weizhouapache]

thanks @DaanHoogland @slavkap
merging

[weizhouapache]

the latest build succeeded.
https://github.com/apache/cloudstack/actions/runs/5829634800/job/15809484444