Skip to content

Remove powermock from xenserver hypervisor plugin#7806

Merged
DaanHoogland merged 1 commit into
apache:mainfrom
shapeblue:remove-powermock-xenserver
Aug 4, 2023
Merged

Remove powermock from xenserver hypervisor plugin#7806
DaanHoogland merged 1 commit into
apache:mainfrom
shapeblue:remove-powermock-xenserver

Conversation

@vishesh92

@vishesh92 vishesh92 commented Aug 2, 2023

Copy link
Copy Markdown
Member

Description

This PR removes powermock from xenserver hypervisor plugin

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

@vishesh92

Copy link
Copy Markdown
Member Author

@blueorangutan package

@blueorangutan

Copy link
Copy Markdown

@vishesh92 a [SF] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@blueorangutan

Copy link
Copy Markdown

Packaging result [SF]: ✖️ el7 ✖️ el8 ✖️ el9 ✖️ debian ✖️ suse15. SL-JID 6630

@vishesh92
vishesh92 force-pushed the remove-powermock-xenserver branch from 3dcd779 to 3075cb8 Compare August 2, 2023 21:52
@codecov

codecov Bot commented Aug 2, 2023

Copy link
Copy Markdown

Codecov Report

Merging #7806 (6089787) into main (7ee697f) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##               main    #7806   +/-   ##
=========================================
  Coverage     13.43%   13.43%           
  Complexity     9394     9394           
=========================================
  Files          2747     2747           
  Lines        258853   258853           
  Branches      40313    40313           
=========================================
  Hits          34785    34785           
+ Misses       219689   219686    -3     
- Partials       4379     4382    +3     

see 2 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@harikrishna-patnala harikrishna-patnala left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vishesh92 This PR should increase the coverage right! any idea why it is decreasing?
image

@vishesh92

Copy link
Copy Markdown
Member Author

@harikrishna-patnala Even I am not sure. The files it is listing are in a completely different module. In intellij, running xenserver tests on main are not generating coverage for the below files either.

image

@vishesh92 vishesh92 closed this Aug 3, 2023
@vishesh92 vishesh92 reopened this Aug 3, 2023
@vishesh92

Copy link
Copy Markdown
Member Author

@blueorangutan package

@blueorangutan

Copy link
Copy Markdown

@vishesh92 a [SF] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@blueorangutan

Copy link
Copy Markdown

Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 6638

@DaanHoogland DaanHoogland left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clgtm

@vishesh92
vishesh92 force-pushed the remove-powermock-xenserver branch from 3075cb8 to 6089787 Compare August 3, 2023 19:53
@vishesh92

Copy link
Copy Markdown
Member Author

@blueorangutan package

@blueorangutan

Copy link
Copy Markdown

@vishesh92 a [SF] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@blueorangutan

Copy link
Copy Markdown

Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 6657

@vishesh92

Copy link
Copy Markdown
Member Author

@vishesh92 This PR should increase the coverage right! any idea why it is decreasing? image

It was an issue with code coverage. I could see similar output for other PRs as well. Rebasing with latest main fixed the issue.

@harikrishna-patnala harikrishna-patnala left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM.

@DaanHoogland
DaanHoogland merged commit 90443cd into apache:main Aug 4, 2023
@DaanHoogland
DaanHoogland deleted the remove-powermock-xenserver branch August 4, 2023 08:26
@DaanHoogland DaanHoogland added this to the 4.19.0.0 milestone Sep 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants