Skip to content

server: fix nic device id for imported vm#6953

Merged
yadvr merged 1 commit into
apache:4.17from
shapeblue:fix-importedvm-nicdeviceid
Dec 8, 2022
Merged

server: fix nic device id for imported vm#6953
yadvr merged 1 commit into
apache:4.17from
shapeblue:fix-importedvm-nicdeviceid

Conversation

@shwstppr

@shwstppr shwstppr commented Dec 7, 2022 •
edited
Loading

Copy link
Copy Markdown
Contributor

Description

Fixes #6951

Adds deviceid for NICs of an imported VM. Device Id will be set 0..n in the order in which they are returned by hypervisor.

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

importvm-nics.mp4

How Has This Been Tested?

@shwstppr
server: fix nic device id fro imported vm
480048b 
Fixes apache#6951

Adds deviceid for NICs of an imported VM. Device Id will be set 0..n in the order which they are returned by hypervisor.

Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
@sonarqubecloud

sonarqubecloud Bot commented Dec 7, 2022

Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

85.7% 85.7% Coverage
0.0% 0.0% Duplication

harikrishna-patnala
harikrishna-patnala approved these changes Dec 7, 2022
View reviewed changes

@harikrishna-patnala harikrishna-patnala left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good to me.

@codecov

codecov Bot commented Dec 7, 2022 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #6953 (480048b) into 4.17 (d182eac) will increase coverage by 0.02%.
The diff coverage is 75.00%.

@@             Coverage Diff              @@
##               4.17    #6953      +/-   ##
============================================
+ Coverage     10.34%   10.36%   +0.02%     
- Complexity     6612     6629      +17     
============================================
  Files          2451     2451              
  Lines        242356   242357       +1     
  Branches      37926    37928       +2     
============================================
+ Hits          25067    25123      +56     
+ Misses       214199   214131      -68     
- Partials       3090     3103      +13
Impacted Files Coverage Δ
.../apache/cloudstack/vm/UnmanagedVMsManagerImpl.java 31.50% <75.00%> (-0.13%) ⬇️
...dstack/network/contrail/model/ModelObjectBase.java 21.15% <0.00%> (-7.70%) ⬇️
...oud/hypervisor/vmware/mo/HypervisorHostHelper.java 15.55% <0.00%> (+0.22%) ⬆️
...com/cloud/hypervisor/vmware/util/VmwareHelper.java 2.34% <0.00%> (+0.52%) ⬆️
...va/com/cloud/hypervisor/vmware/mo/DatastoreMO.java 2.40% <0.00%> (+2.40%) ⬆️
...visor/vmware/manager/VmwareStorageManagerImpl.java 6.23% <0.00%> (+5.17%) ⬆️
...d/hypervisor/vmware/mo/HostDatastoreBrowserMO.java 17.07% <0.00%> (+14.63%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@yadvr

yadvr commented Dec 7, 2022

Copy link
Copy Markdown
Member

@blueorangutan package

@blueorangutan

blueorangutan commented Dec 7, 2022

Copy link
Copy Markdown

@rohityadavcloud a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@yadvr yadvr added this to the 4.17.2.0 milestone Dec 7, 2022
@yadvr
yadvr marked this pull request as ready for review December 7, 2022 16:36
@blueorangutan

blueorangutan commented Dec 7, 2022

Copy link
Copy Markdown

Packaging result: ✔️ el7 ✔️ el8 ✔️ debian ✔️ suse15. SL-JID 4804

@yadvr

yadvr commented Dec 8, 2022

Copy link
Copy Markdown
Member

@blueorangutan test matrix

@blueorangutan

blueorangutan commented Dec 8, 2022

Copy link
Copy Markdown

@rohityadavcloud a Trillian-Jenkins matrix job (centos7 mgmt + xs71, centos7 mgmt + vmware65, centos7 mgmt + kvmcentos7) has been kicked to run smoke tests

@shwstppr shwstppr changed the title server: fix nic device id fro imported vm server: fix nic device id for imported vm Dec 8, 2022
@blueorangutan

blueorangutan commented Dec 8, 2022

Copy link
Copy Markdown

Trillian test result (tid-5422)
Environment: xenserver-71 (x2), Advanced Networking with Mgmt server 7
Total time taken: 35085 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr6953-t5422-xenserver-71.zip
Smoke tests completed. 101 look OK, 0 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test Result Time (s) Test File

@blueorangutan

blueorangutan commented Dec 8, 2022

Copy link
Copy Markdown

Trillian test result (tid-5423)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 43319 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr6953-t5423-kvm-centos7.zip
Smoke tests completed. 100 look OK, 1 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test Result Time (s) Test File
test_08_upgrade_kubernetes_ha_cluster Failure 550.28 test_kubernetes_clusters.py

@blueorangutan

blueorangutan commented Dec 8, 2022

Copy link
Copy Markdown

Trillian test result (tid-5424)
Environment: vmware-65u2 (x2), Advanced Networking with Mgmt server 7
Total time taken: 45259 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr6953-t5424-vmware-65u2.zip
Smoke tests completed. 100 look OK, 1 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test Result Time (s) Test File
test_08_upgrade_kubernetes_ha_cluster Failure 3651.84 test_kubernetes_clusters.py
test_09_delete_kubernetes_ha_cluster Failure 0.08 test_kubernetes_clusters.py
ContextSuite context=TestKubernetesCluster>:teardown Error 42.03 test_kubernetes_clusters.py

@yadvr
yadvr merged commit b7f845a into apache:4.17 Dec 8, 2022
@yadvr yadvr mentioned this pull request Dec 8, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yadvr yadvr yadvr approved these changes
@harikrishna-patnala harikrishna-patnala harikrishna-patnala approved these changes
+1 more reviewer
@alexandremattioli alexandremattioli alexandremattioli approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

4.17.2.0

Development

Successfully merging this pull request may close these issues.

5 participants

@shwstppr @yadvr @blueorangutan @harikrishna-patnala @alexandremattioli