systemvm,vpc,vmware: fix management route by shwstppr · Pull Request #6921 · apache/cloudstack

shwstppr · 2022-11-24T09:18:54Z

Description

Fixes #6873
When the management server is in a different subnet than the pod in which a VPC VR is deployed, an ip route must be added just after creation of eth0 to allow the connectivity between the VR and the management server.

Types of changes

Breaking change (fix or feature that would cause existing functionality to change)
New feature (non-breaking change which adds functionality)
Bug fix (non-breaking change which fixes an issue)
Enhancement (improves an existing feature and functionality)
Cleanup (Code refactoring and cleanup, that may add test cases)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

Major
Minor

Bug Severity

Screenshots (if appropriate):

How Has This Been Tested?

Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>

codecov · 2022-11-24T12:31:35Z

Codecov Report

Merging #6921 (fc74ab3) into 4.17 (7f760cc) will increase coverage by 0.00%.
The diff coverage is n/a.

@@            Coverage Diff            @@
##               4.17    #6921   +/-   ##
=========================================
  Coverage     10.36%   10.36%           
- Complexity     6629     6631    +2     
=========================================
  Files          2451     2451           
  Lines        242357   242357           
  Branches      37928    37928           
=========================================
+ Hits          25123    25127    +4     
+ Misses       214131   214127    -4     
  Partials       3103     3103

Impacted Files	Coverage Δ
...apache/cloudstack/syslog/AlertsSyslogAppender.java	`58.75% <0.00%> (+2.25%)`	⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

shwstppr · 2022-11-25T05:34:34Z

@blueorangutan package

blueorangutan · 2022-11-25T05:35:03Z

@shwstppr a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2022-11-25T06:38:59Z

Packaging result: ✔️ el7 ✔️ el8 ✔️ debian ✔️ suse15. SL-JID 4644

DaanHoogland · 2022-11-28T17:05:15Z

@blueorangutan test

blueorangutan · 2022-11-28T17:06:03Z

@DaanHoogland a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

blueorangutan · 2022-11-28T17:22:15Z

Trillian Build Failed (tid-5271)

Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>

Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>

shwstppr · 2022-12-06T05:17:29Z

@blueorangutan package

blueorangutan · 2022-12-06T05:18:03Z

@shwstppr a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>

shwstppr · 2022-12-06T07:39:43Z

@blueorangutan package

blueorangutan · 2022-12-06T07:40:03Z

@shwstppr a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2022-12-06T08:32:04Z

Packaging result: ✔️ el7 ✔️ el8 ✔️ debian ✔️ suse15. SL-JID 4775

blueorangutan · 2022-12-06T08:32:04Z

Packaging result: ✔️ el7 ✔️ el8 ✔️ debian ✔️ suse15. SL-JID 4773

yadvr · 2022-12-07T07:42:24Z

@blueorangutan systemvmbuild

blueorangutan · 2022-12-07T07:42:48Z

@rohityadavcloud a Jenkins job has been kicked to build the systemvmtemplate. I'll keep you posted as I make progress.

yadvr · 2022-12-09T16:18:12Z

@blueorangutan test matrix

blueorangutan · 2022-12-09T16:19:06Z

@rohityadavcloud a Trillian-Jenkins matrix job (centos7 mgmt + xs71, centos7 mgmt + vmware65, centos7 mgmt + kvmcentos7) has been kicked to run smoke tests

blueorangutan · 2022-12-09T16:57:29Z

Trillian Build Failed (tid-5450)

blueorangutan · 2022-12-09T16:58:46Z

Trillian Build Failed (tid-5448)

blueorangutan · 2022-12-09T17:01:18Z

Trillian Build Failed (tid-5449)

yadvr · 2022-12-10T02:51:17Z

@blueorangutan test matrix

blueorangutan · 2022-12-10T02:52:03Z

@rohityadavcloud a Trillian-Jenkins matrix job (centos7 mgmt + xs71, centos7 mgmt + vmware65, centos7 mgmt + kvmcentos7) has been kicked to run smoke tests

blueorangutan · 2022-12-10T13:24:39Z

Trillian test result (tid-5453)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 36579 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr6921-t5453-kvm-centos7.zip
Smoke tests completed. 100 look OK, 1 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File
test_01_unmanage_vm_cycle	`Error`	33.76	test_vm_lifecycle_unmanage_import.py
ContextSuite context=TestUnmanageVM>:teardown	`Error`	33.78	test_vm_lifecycle_unmanage_import.py

blueorangutan · 2022-12-10T14:11:47Z

Trillian test result (tid-5454)
Environment: vmware-65u2 (x2), Advanced Networking with Mgmt server 7
Total time taken: 39647 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr6921-t5454-vmware-65u2.zip
Smoke tests completed. 101 look OK, 0 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File

blueorangutan · 2022-12-10T14:44:50Z

Trillian test result (tid-5452)
Environment: xenserver-71 (x2), Advanced Networking with Mgmt server 7
Total time taken: 41510 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr6921-t5452-xenserver-71.zip
Smoke tests completed. 99 look OK, 2 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File
test_01_unmanage_vm_cycle	`Error`	35.73	test_vm_lifecycle_unmanage_import.py
ContextSuite context=TestUnmanageVM>:teardown	`Error`	35.76	test_vm_lifecycle_unmanage_import.py
test_02_cancel_host_maintenace_with_migration_jobs	`Error`	1511.65	test_host_maintenance.py

yadvr · 2022-12-10T16:26:48Z

@blueorangutan test

blueorangutan · 2022-12-10T16:27:03Z

@rohityadavcloud a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

blueorangutan · 2022-12-11T04:21:50Z

Trillian test result (tid-5457)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 41570 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr6921-t5457-kvm-centos7.zip
Smoke tests completed. 99 look OK, 2 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File
test_01_unmanage_vm_cycle	`Error`	31.73	test_vm_lifecycle_unmanage_import.py
ContextSuite context=TestUnmanageVM>:teardown	`Error`	31.77	test_vm_lifecycle_unmanage_import.py
test_03_create_redundant_VPC_1tier_2VMs_2IPs_2PF_ACL_reboot_routers	`Failure`	467.97	test_vpc_redundant.py

yadvr · 2022-12-12T05:04:21Z

@blueorangutan package

blueorangutan · 2022-12-12T05:05:03Z

@rohityadavcloud a Jenkins job has been kicked to build packages. It will be bundled with SystemVM template(s). I'll keep you posted as I make progress.

blueorangutan · 2022-12-12T05:44:07Z

Packaging result: ✔️ el7 ✔️ el8 ✔️ debian ✔️ suse15. SL-JID 4843

yadvr · 2022-12-12T06:02:31Z

@blueorangutan test matrix

blueorangutan · 2022-12-12T06:03:03Z

@rohityadavcloud a Trillian-Jenkins matrix job (centos7 mgmt + xs71, centos7 mgmt + vmware65, centos7 mgmt + kvmcentos7) has been kicked to run smoke tests

vladimirpetrov

LGTM based on manual testing.

blueorangutan · 2022-12-12T16:46:45Z

Trillian test result (tid-5460)
Environment: xenserver-71 (x2), Advanced Networking with Mgmt server 7
Total time taken: 37424 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr6921-t5460-xenserver-71.zip
Smoke tests completed. 101 look OK, 0 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File

blueorangutan · 2022-12-12T17:33:46Z

Trillian test result (tid-5462)
Environment: vmware-65u2 (x2), Advanced Networking with Mgmt server 7
Total time taken: 40365 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr6921-t5462-vmware-65u2.zip
Smoke tests completed. 101 look OK, 0 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File

blueorangutan · 2022-12-12T19:20:49Z

Trillian test result (tid-5461)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 46548 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr6921-t5461-kvm-centos7.zip
Smoke tests completed. 100 look OK, 1 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File
test_03_deploy_and_scale_kubernetes_cluster	`Failure`	3628.87	test_kubernetes_clusters.py

systemvm,vpc,vmware: fix management route

7b58c71

Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>

boring-cyborg Bot added component:networking component:virtual-router labels Nov 24, 2022

shwstppr linked an issue Nov 24, 2022 that may be closed by this pull request

VPC VR can't be started on VMware due to missing routes #6873

Closed

yadvr added the status:needs-testing label Nov 24, 2022

fix missing command

f5c33a3

Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>

yadvr added this to the 4.17.2.0 milestone Nov 24, 2022

shwstppr and others added 2 commits December 5, 2022 15:56

fix

890a003

Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>

fix build

68c7ed6

Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>

boring-cyborg Bot added component:templates component:systemvm-template labels Dec 5, 2022

log message edit

2aa3f4c

Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>

apache deleted a comment from blueorangutan Dec 7, 2022

apache deleted a comment from blueorangutan Dec 9, 2022

vladimirpetrov approved these changes Dec 12, 2022

View reviewed changes

yadvr merged commit 5516f74 into apache:4.17 Dec 12, 2022

yadvr deleted the fix-vmw-vpc-mgmtroute branch December 12, 2022 12:11

yadvr mentioned this pull request Dec 12, 2022

VPC VR can't be started on VMware due to missing routes #6873

Closed

DaanHoogland removed the status:needs-testing label Jan 28, 2026

Uh oh!

Conversation

shwstppr commented Nov 24, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Types of changes

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

Bug Severity

Screenshots (if appropriate):

How Has This Been Tested?

Uh oh!

codecov Bot commented Nov 24, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

shwstppr commented Nov 25, 2022

Uh oh!

blueorangutan commented Nov 25, 2022

Uh oh!

blueorangutan commented Nov 25, 2022

Uh oh!

DaanHoogland commented Nov 28, 2022

Uh oh!

blueorangutan commented Nov 28, 2022

Uh oh!

blueorangutan commented Nov 28, 2022

Uh oh!

shwstppr commented Dec 6, 2022

Uh oh!

blueorangutan commented Dec 6, 2022

Uh oh!

shwstppr commented Dec 6, 2022

Uh oh!

blueorangutan commented Dec 6, 2022

Uh oh!

blueorangutan commented Dec 6, 2022

Uh oh!

blueorangutan commented Dec 6, 2022

Uh oh!

yadvr commented Dec 7, 2022

Uh oh!

blueorangutan commented Dec 7, 2022

Uh oh!

yadvr commented Dec 9, 2022

Uh oh!

blueorangutan commented Dec 9, 2022

Uh oh!

blueorangutan commented Dec 9, 2022

Uh oh!

blueorangutan commented Dec 9, 2022

Uh oh!

blueorangutan commented Dec 9, 2022

Uh oh!

yadvr commented Dec 10, 2022

Uh oh!

blueorangutan commented Dec 10, 2022

Uh oh!

blueorangutan commented Dec 10, 2022

Uh oh!

blueorangutan commented Dec 10, 2022

Uh oh!

blueorangutan commented Dec 10, 2022

Uh oh!

yadvr commented Dec 10, 2022

Uh oh!

blueorangutan commented Dec 10, 2022

Uh oh!

blueorangutan commented Dec 11, 2022

Uh oh!

yadvr commented Dec 12, 2022

Uh oh!

blueorangutan commented Dec 12, 2022

Uh oh!

blueorangutan commented Dec 12, 2022

Uh oh!

yadvr commented Dec 12, 2022

Uh oh!

blueorangutan commented Dec 12, 2022

Uh oh!

shwstppr commented Nov 24, 2022 •

edited

Loading

codecov Bot commented Nov 24, 2022 •

edited

Loading