vmware: fix vmware vm snapshot operations for datastorecluster

[shwstppr]

Description

Fixes #6894

Fixes NPE observed when VM volume is present on the same child datastore.

Types of changes

• Breaking change (fix or feature that would cause existing functionality to change)
• New feature (non-breaking change which adds functionality)
• Bug fix (non-breaking change which fixes an issue)
• Enhancement (improves an existing feature and functionality)
• Cleanup (Code refactoring and cleanup, that may add test cases)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

• Major
• Minor

Bug Severity

• BLOCKER
• Critical
• Major
• Minor
• Trivial

Screenshots (if appropriate):

How Has This Been Tested?

[sonarqubecloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

0.0% Coverage
0.0% Duplication

[shwstppr]

@blueorangutan package

[blueorangutan]

@shwstppr a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

[blueorangutan]

Packaging result: ✔️ el7 ✔️ el8 ✔️ debian ✔️ suse15. SL-JID 4637

[yadvr]

@harikrishna-patnala can you review and help test/check this?

[codecov]

Codecov Report

Merging #6912 (2eb49a9) into 4.17 (296035d) will increase coverage by 0.02%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##               4.17    #6912      +/-   ##
============================================
+ Coverage     10.34%   10.36%   +0.02%     
- Complexity     6610     6628      +18     
============================================
  Files          2451     2451              
  Lines        242340   242341       +1     
  Branches      37924    37925       +1     
============================================
+ Hits          25070    25122      +52     
+ Misses       214182   214119      -63     
- Partials       3088     3100      +12     

Impacted Files	Coverage Δ
...visor/vmware/manager/VmwareStorageManagerImpl.java	6.23% <100.00%> (+5.17%)	⬆️
...rg/apache/cloudstack/quota/QuotaStatementImpl.java	36.28% <0.00%> (-3.99%)	⬇️
...oud/hypervisor/vmware/mo/HypervisorHostHelper.java	15.55% <0.00%> (+0.22%)	⬆️
...com/cloud/hypervisor/vmware/util/VmwareHelper.java	2.34% <0.00%> (+0.52%)	⬆️
...va/com/cloud/hypervisor/vmware/mo/DatastoreMO.java	2.40% <0.00%> (+2.40%)	⬆️
...d/hypervisor/vmware/mo/HostDatastoreBrowserMO.java	17.07% <0.00%> (+14.63%)	⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

[shwstppr]

blueorangutan test centos7 vmware-67u3

[yadvr]

@blueorangutan test centos7 vmware-67u3

[blueorangutan]

@rohityadavcloud a Trillian-Jenkins test job (centos7 mgmt + vmware-67u3) has been kicked to run smoke tests

[blueorangutan]

Trillian test result (tid-5263)
Environment: vmware-67u3 (x2), Advanced Networking with Mgmt server 7
Total time taken: 41604 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr6912-t5263-vmware-67u3.zip
Smoke tests completed. 100 look OK, 1 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File
test_08_upgrade_kubernetes_ha_cluster	Failure	626.98	test_kubernetes_clusters.py

[yadvr]

@harikrishna-patnala can you help review/test this?

[harikrishna-patnala]

LGTM, discussed this fix with Abhishek before. Thanks for the unit tests @shwstppr

[nvazquez]

Code LGTM

[DaanHoogland]

@harikrishna-patnala @nvazquez @rohityadavcloud @shwstppr does this need more testing?

[vladimirpetrov]

Yes, @DaanHoogland, I'm going to test this.

[vladimirpetrov]

@blueorangutan package

[blueorangutan]

@vladimirpetrov a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

[blueorangutan]

Packaging result: ✔️ el7 ✔️ el8 ✔️ debian ✔️ suse15. SL-JID 4721

[yadvr]

@blueorangutan test rocky8 vmware-70u3

[blueorangutan]

@rohityadavcloud a Trillian-Jenkins test job (rocky8 mgmt + vmware-70u3) has been kicked to run smoke tests

[blueorangutan]

Trillian Build Failed (tid-5351)

[blueorangutan]

Trillian Build Failed (tid-5386)

[vladimirpetrov]

LGTM based on manual testing.

[yadvr]

@blueorangutan test rocky8 vmware-70u3

[blueorangutan]

@rohityadavcloud a Trillian-Jenkins test job (rocky8 mgmt + vmware-70u3) has been kicked to run smoke tests

[blueorangutan]

Trillian Build Failed (tid-5412)