Skip to content

UI: Fix Volume Snapshot from user VM as admin#6824

Merged
DaanHoogland merged 1 commit into
apache:4.17from
shapeblue:fix-ui-takesnapshot-from-volume
Oct 13, 2022
Merged

UI: Fix Volume Snapshot from user VM as admin#6824
DaanHoogland merged 1 commit into
apache:4.17from
shapeblue:fix-ui-takesnapshot-from-volume

Conversation

@nvazquez

Copy link
Copy Markdown
Contributor

Description

Fixes: #6795

Screen Shot 2022-10-12 at 13 09 27

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

Take volume snapshots for user VMs from the instance view as admin, the volume is correctly displayed and snapshot operation succeeded

@acs-robot

Copy link
Copy Markdown

Found UI changes, kicking a new UI QA build
@blueorangutan ui

@blueorangutan

Copy link
Copy Markdown

@acs-robot a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

@blueorangutan

Copy link
Copy Markdown

UI build: ✔️
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/6824 (SL-JID-2486)

@sonarqubecloud

Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@codecov

codecov Bot commented Oct 12, 2022

Copy link
Copy Markdown

Codecov Report

Merging #6824 (d2bf60d) into 4.17 (6a0c907) will increase coverage by 0.26%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##               4.17    #6824      +/-   ##
============================================
+ Coverage     10.34%   10.61%   +0.26%     
- Complexity     6611     6862     +251     
============================================
  Files          2451     2466      +15     
  Lines        242340   244539    +2199     
  Branches      37924    38272     +348     
============================================
+ Hits          25067    25949     +882     
- Misses       214185   215308    +1123     
- Partials       3088     3282     +194     
Impacted Files Coverage Δ
.../cloudstack/api/response/ApiDiscoveryResponse.java 0.00% <0.00%> (-100.00%) ⬇️
.../cloudstack/api/response/ApiParameterResponse.java 0.00% <0.00%> (-100.00%) ⬇️
...e/cloudstack/api/response/ApiResponseResponse.java 0.00% <0.00%> (-80.00%) ⬇️
.../cloudstack/discovery/ApiDiscoveryServiceImpl.java 13.93% <0.00%> (-55.25%) ⬇️
...rce/wrapper/LibvirtResizeVolumeCommandWrapper.java 49.50% <0.00%> (-27.17%) ⬇️
...rc/main/java/com/cloud/storage/StorageManager.java 76.92% <0.00%> (-23.08%) ⬇️
.../cloud/hypervisor/kvm/storage/KVMPhysicalDisk.java 70.27% <0.00%> (-10.98%) ⬇️
...pper/LibvirtPrepareForMigrationCommandWrapper.java 43.10% <0.00%> (-10.09%) ⬇️
.../cloudstack/ratelimit/ApiRateLimitServiceImpl.java 68.88% <0.00%> (-4.45%) ⬇️
...rg/apache/cloudstack/quota/QuotaStatementImpl.java 36.28% <0.00%> (-3.99%) ⬇️
... and 165 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@DaanHoogland DaanHoogland left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clgtm

@kohrar

kohrar commented Oct 12, 2022

Copy link
Copy Markdown
Contributor

Tested and fixes the issue for me. Thank-you @nvazquez

@DaanHoogland
DaanHoogland merged commit 79e5e7f into apache:4.17 Oct 13, 2022
DaanHoogland pushed a commit to shapeblue/cloudstack that referenced this pull request Oct 20, 2022
DaanHoogland added a commit that referenced this pull request Oct 20, 2022
* 4.17:
  UI: Fix Volume Snapshot from user VM as admin (#6824)
@yadvr yadvr modified the milestones: 4.18.0.0, 4.17.2.0 Nov 24, 2022
@nvazquez
nvazquez deleted the fix-ui-takesnapshot-from-volume branch January 30, 2023 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

UI: admin cannot take volume snapshot on user VM

7 participants