Skip to content

Fix SQL query for uuid wrong format #6654

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
shwstppr merged 2 commits into from
Aug 19, 2022
Merged

Fix SQL query for uuid wrong format #6654

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
21b9ad1
Fix SQL query for uuid wrong format
nvazquez Aug 17, 2022
95ca91d
Restrict the SQL to datastorecluster
nvazquez Aug 18, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions engine/schema/src/main/java/com/cloud/upgrade/dao/Upgrade41610to41700.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@ public InputStream[] getPrepareScripts() {

@Override
public void performDataMigration(Connection conn) {
fixWrongPoolUuid(conn);
fixWrongDatastoreClusterPoolUuid(conn);
}

@Override
Expand Down Expand Up @@ -90,10 +90,11 @@ public void updateSystemVmTemplates(Connection conn) {
}
}

public void fixWrongPoolUuid(Connection conn) {
LOG.debug("Replacement of faulty pool uuids");
public void fixWrongDatastoreClusterPoolUuid(Connection conn) {
LOG.debug("Replacement of faulty pool uuids on datastorecluster");
try (PreparedStatement pstmt = conn.prepareStatement("SELECT id,uuid FROM storage_pool "
+ "WHERE uuid NOT LIKE \"%-%-%-%\" AND removed IS NULL;"); ResultSet rs = pstmt.executeQuery()) {
+ "WHERE uuid NOT LIKE \"%-%-%-%\" AND removed IS NULL "
+ "AND pool_type = 'DatastoreCluster';"); ResultSet rs = pstmt.executeQuery()) {
PreparedStatement updateStmt = conn.prepareStatement("update storage_pool set uuid = ? where id = ?");
while (rs.next()) {
UUID poolUuid = new UUID(
Expand Down