vmware: fix vm snapshot with datastore cluster, drs

[shwstppr]

Description

Fixes #6595

Types of changes

• Breaking change (fix or feature that would cause existing functionality to change)
• New feature (non-breaking change which adds functionality)
• Bug fix (non-breaking change which fixes an issue)
• Enhancement (improves an existing feature and functionality)
• Cleanup (Code refactoring and cleanup, that may add test cases)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

• Major
• Minor

Bug Severity

• BLOCKER
• Critical
• Major
• Minor
• Trivial

Screenshots (if appropriate):

How Has This Been Tested?

[shwstppr]

@blueorangutan package

[blueorangutan]

@shwstppr a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

[blueorangutan]

Packaging result: ✔️ el7 ✔️ el8 ✔️ debian ✔️ suse15. SL-JID 4039

[codecov]

Codecov Report

Merging #6643 (39f3ecc) into 4.17 (76f52af) will increase coverage by 0.00%.
The diff coverage is 7.92%.

@@            Coverage Diff            @@
##               4.17    #6643   +/-   ##
=========================================
  Coverage      5.86%    5.87%           
- Complexity     3918     3927    +9     
=========================================
  Files          2451     2451           
  Lines        242256   242305   +49     
  Branches      37907    37919   +12     
=========================================
+ Hits          14207    14230   +23     
- Misses       226479   226502   +23     
- Partials       1570     1573    +3     

Impacted Files	Coverage Δ
...dstack/storage/datastore/PrimaryDataStoreImpl.java	2.29% <0.00%> (-0.10%)	⬇️
...visor/vmware/manager/VmwareStorageManagerImpl.java	1.06% <0.00%> (-0.03%)	⬇️
...oud/hypervisor/vmware/resource/VmwareResource.java	0.00% <0.00%> (ø)
...esource/VmwareSecondaryStorageResourceHandler.java	0.00% <0.00%> (ø)
...cloud/storage/resource/VmwareStorageProcessor.java	0.32% <0.00%> (+<0.01%)	⬆️
.../storage/vmsnapshot/DefaultVMSnapshotStrategy.java	54.92% <66.66%> (+2.58%)	⬆️
...oud/hypervisor/vmware/mo/HypervisorHostHelper.java	15.33% <0.00%> (-0.07%)	⬇️
...ervisor/kvm/resource/LibvirtComputingResource.java	15.98% <0.00%> (-0.01%)	⬇️
.../src/main/java/com/cloud/vm/UserVmManagerImpl.java	0.00% <0.00%> (ø)
...ain/java/com/cloud/network/NetworkServiceImpl.java	0.00% <0.00%> (ø)
... and 5 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

[shwstppr]

@blueorangutan test matrix

[blueorangutan]

@shwstppr a Trillian-Jenkins matrix job (centos7 mgmt + xs71, centos7 mgmt + vmware65, centos7 mgmt + kvmcentos7) has been kicked to run smoke tests

[blueorangutan]

Trillian test result (tid-4750)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 39578 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr6643-t4750-kvm-centos7.zip
Smoke tests completed. 100 look OK, 1 have errors
Only failed tests results shown below:

Test	Result	Time (s)	Test File
test_08_upgrade_kubernetes_ha_cluster	Failure	624.87	test_kubernetes_clusters.py

[blueorangutan]

Trillian test result (tid-4749)
Environment: xenserver-71 (x2), Advanced Networking with Mgmt server 7
Total time taken: 40154 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr6643-t4749-xenserver-71.zip
Smoke tests completed. 101 look OK, 0 have errors
Only failed tests results shown below:

Test	Result	Time (s)	Test File

[blueorangutan]

Trillian test result (tid-4751)
Environment: vmware-65u2 (x2), Advanced Networking with Mgmt server 7
Total time taken: 42466 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr6643-t4751-vmware-65u2.zip
Smoke tests completed. 100 look OK, 1 have errors
Only failed tests results shown below:

Test	Result	Time (s)	Test File
test_change_service_offering_for_vm_with_snapshots	Error	131.34	test_vm_snapshots.py
test_01_create_vm_snapshots	Error	126.77	test_vm_snapshots.py
test_02_revert_vm_snapshots	Failure	90.26	test_vm_snapshots.py
test_03_delete_vm_snapshots	Error	2.10	test_vm_snapshots.py

[blueorangutan]

@shwstppr a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

[shwstppr]

@blueorangutan package

[blueorangutan]

@shwstppr a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

[blueorangutan]

Packaging result: ✔️ el7 ✔️ el8 ✔️ debian ✔️ suse15. SL-JID 4050

[shwstppr]

@blueorangutan package

[blueorangutan]

@shwstppr a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

[acs-robot]

Found UI changes, kicking a new UI QA build
@blueorangutan ui

[blueorangutan]

@acs-robot a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

[blueorangutan]

UI build: ✔️
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/6643 (SL-JID-2224)

[blueorangutan]

Packaging result: ✔️ el7 ✔️ el8 ✖️ debian ✔️ suse15. SL-JID 4055

[sonarqubecloud]

SonarCloud Quality Gate failed.   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

8.2% Coverage
0.0% Duplication

[shwstppr]

@blueorangutan test centos7 vmware-67u3

[blueorangutan]

@shwstppr a Trillian-Jenkins test job (centos7 mgmt + vmware-67u3) has been kicked to run smoke tests

[yadvr]

@blueorangutan test centos7 vmware-70u2

[blueorangutan]

@rohityadavcloud a Trillian-Jenkins test job (centos7 mgmt + vmware-70u2) has been kicked to run smoke tests

[blueorangutan]

Trillian Build Failed (tid-4764)

[blueorangutan]

Trillian test result (tid-4760)
Environment: vmware-67u3 (x2), Advanced Networking with Mgmt server 7
Total time taken: 43546 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr6643-t4760-vmware-67u3.zip
Smoke tests completed. 101 look OK, 0 have errors
Only failed tests results shown below:

Test	Result	Time (s)	Test File

[yadvr]

@shwstppr is this good to merge or are we looking for another review or manual test?

[shwstppr]

@rohityadavcloud this is being manually tested by @NuxRo

[NuxRo]

LGTM