Skip to content

kvm: add support nicAdapter detail for vm and template settings for KVM#6536

Merged
yadvr merged 1 commit into
apache:4.17from
shapeblue:kvm-nic-adapter-ui-api
Jul 7, 2022
Merged

kvm: add support nicAdapter detail for vm and template settings for KVM#6536
yadvr merged 1 commit into
apache:4.17from
shapeblue:kvm-nic-adapter-ui-api

Conversation

@yadvr

@yadvr yadvr commented Jul 7, 2022

Copy link
Copy Markdown
Member

Fixes #6533

This adds the option returned in API which in turn shows the option and possible values in the UI.

Fixes apache#6533

Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
@yadvr yadvr added this to the 4.17.1.0 milestone Jul 7, 2022
@yadvr

yadvr commented Jul 7, 2022

Copy link
Copy Markdown
Member Author

@blueorangutan package

@blueorangutan

Copy link
Copy Markdown

@rohityadavcloud a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@blueorangutan

Copy link
Copy Markdown

Packaging result: ✔️ el7 ✔️ el8 ✔️ debian ✔️ suse15. SL-JID 3721

@yadvr

yadvr commented Jul 7, 2022

Copy link
Copy Markdown
Member Author

@blueorangutan test

@blueorangutan

Copy link
Copy Markdown

@rohityadavcloud a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

@sonarqubecloud

sonarqubecloud Bot commented Jul 7, 2022

Copy link
Copy Markdown

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell D 1 Code Smell

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@sureshanaparti sureshanaparti left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code LGTM, needs testing (mainly, with nic adapter and root disk controller options)

@harikrishna-patnala

Copy link
Copy Markdown
Member

Changes wrt PR looks good and I can see the "nicAdapter" from VM settings. When I change/set the nicAdapter the interface is set accordingly on the VM.

One observation I've made with the "rootDiskController" during this testing is,
If rootDiskController is changed to "ide" then it is not reflected on VM.
@sureshanaparti do you think it's an issue to be fixed, not in this PR but as a separate one.

cc @rohityadavcloud @GabrielBrascher @weizhouapache any suggestion here.

@Pearl1594

Copy link
Copy Markdown
Contributor

@harikrishna-patnala wrt to rootdiskcontroller setting, if the root disk and data disk controller settings are already defined on the template, then they take precedence over the setting on the VM - PR: #6276 attempts to fix that anomaly.

@Pearl1594 Pearl1594 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yadvr
yadvr merged commit d8da5e6 into apache:4.17 Jul 7, 2022
@yadvr
yadvr deleted the kvm-nic-adapter-ui-api branch July 7, 2022 09:08
@yadvr

yadvr commented Jul 7, 2022

Copy link
Copy Markdown
Member Author

Thanks for review/testing @harikrishna-patnala @Pearl1594 @sureshanaparti

@blueorangutan

Copy link
Copy Markdown

Trillian test result (tid-4438)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 40428 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr6536-t4438-kvm-centos7.zip
Smoke tests completed. 97 look OK, 1 have errors
Only failed tests results shown below:

Test Result Time (s) Test File
test_hostha_kvm_host_degraded Error 666.05 test_hostha_kvm.py

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants