kvm: add support nicAdapter detail for vm and template settings for KVM#6536
Conversation
Fixes apache#6533 Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
|
@blueorangutan package |
|
@rohityadavcloud a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. |
|
Packaging result: ✔️ el7 ✔️ el8 ✔️ debian ✔️ suse15. SL-JID 3721 |
|
@blueorangutan test |
|
@rohityadavcloud a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests |
|
SonarCloud Quality Gate failed. |
sureshanaparti
left a comment
There was a problem hiding this comment.
code LGTM, needs testing (mainly, with nic adapter and root disk controller options)
|
Changes wrt PR looks good and I can see the "nicAdapter" from VM settings. When I change/set the nicAdapter the interface is set accordingly on the VM. One observation I've made with the "rootDiskController" during this testing is, cc @rohityadavcloud @GabrielBrascher @weizhouapache any suggestion here. |
|
@harikrishna-patnala wrt to rootdiskcontroller setting, if the root disk and data disk controller settings are already defined on the template, then they take precedence over the setting on the VM - PR: #6276 attempts to fix that anomaly. |
|
Thanks for review/testing @harikrishna-patnala @Pearl1594 @sureshanaparti |
|
Trillian test result (tid-4438)
|









Fixes #6533
This adds the option returned in API which in turn shows the option and possible values in the UI.