Skip to content

UI: Add authmethod field allowing to choose password or ssh key when adding host#6525

Merged
sureshanaparti merged 4 commits into
apache:4.17from
EWERK-DIGITAL:feature/zone-wz-add-host-with-authmethod
Jul 6, 2022
Merged

UI: Add authmethod field allowing to choose password or ssh key when adding host#6525
sureshanaparti merged 4 commits into
apache:4.17from
EWERK-DIGITAL:feature/zone-wz-add-host-with-authmethod

Conversation

@utchoang

@utchoang utchoang commented Jul 4, 2022

Copy link
Copy Markdown

Description

This PR for fixes #6499

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

image
image

How Has This Been Tested?

@acs-robot

Copy link
Copy Markdown

Found UI changes, kicking a new UI QA build
@blueorangutan ui

@blueorangutan

Copy link
Copy Markdown

@acs-robot a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

@blueorangutan

Copy link
Copy Markdown

UI build: ✔️
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/6525 (SL-JID-1890)

@utchoang utchoang changed the title Feature/zone wz add host with authmethod UI: Add authmethod field allowing to choose password or ssh key when adding host Jul 4, 2022
@harikrishna-patnala

Copy link
Copy Markdown
Member

Thanks for the PR @utchoang.
I've quickly tested this and works well for KVM in zone wizard.
image
image

The thing I saw with other hypervisors is the password tab appears under "Authentication Method". Is there a way we can skip both the "Authentication Method" heading and Password tab completely?

Following is the screenshot I saw when I go back and try to add Xenserver cluster and host
image

@acs-robot

Copy link
Copy Markdown

Found UI changes, kicking a new UI QA build
@blueorangutan ui

@acs-robot

Copy link
Copy Markdown

Found UI changes, kicking a new UI QA build
@blueorangutan ui

@blueorangutan

Copy link
Copy Markdown

@acs-robot a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

@blueorangutan

Copy link
Copy Markdown

UI build: ✔️
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/6525 (SL-JID-1893)

@harikrishna-patnala

Copy link
Copy Markdown
Member

Wow, that's quick.

image

I saw the tooltip has gone but I still see this password tab @utchoang.

Also, I just realised "Add host" form also shows the password tab for non-kvm hypervisor types. I don't think it is kept intentionally. What do you say @utchoang

@sonarqubecloud

sonarqubecloud Bot commented Jul 4, 2022

Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@utchoang

utchoang commented Jul 4, 2022

Copy link
Copy Markdown
Author

@harikrishna-patnala Same with "Add Host" it remains for non-KVM hypervisors. I think it's okay to keep it, but if you want I can delete it.
image

@harikrishna-patnala harikrishna-patnala left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, let's keep it the same way here, may be it helps in future when we add it to other hypervisors. Thanks for all the changes @utchoang

LGTM

@sureshanaparti

Copy link
Copy Markdown
Contributor

@blueorangutan ui

@blueorangutan

Copy link
Copy Markdown

@sureshanaparti a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

@blueorangutan

Copy link
Copy Markdown

UI build: ✔️
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/6525 (SL-JID-1912)

@sureshanaparti sureshanaparti left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified zone wizard, LGTM.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants