api,server: custom dns for guest network by shwstppr · Pull Request #6425 · apache/cloudstack

shwstppr · 2022-05-31T07:06:09Z

Description

Adds option to provide custom DNS servers for isolated network, shared network and VPC tier.
New API parameters added in createNetwork API along with the corresponding response parameters.

Doc PR: apache/cloudstack-documentation#276

Types of changes

Breaking change (fix or feature that would cause existing functionality to change)
New feature (non-breaking change which adds functionality)
Bug fix (non-breaking change which fixes an issue)
Enhancement (improves an existing feature and functionality)
Cleanup (Code refactoring and cleanup, that may add test cases)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

Major
Minor

Bug Severity

Screenshots (if appropriate):

How Has This Been Tested?

Manually ran new marvin test:

[root@pr6425-t4310-vmware-67u3-marvin marvin]# nosetests --with-xunit --xunit-file=results.xml --with-marvin --marvin-config=./pr6425-t4310-vmware-67u3-advanced-cfg -s -a tags=advanced --hypervisor=VMware tests/component/test_network_vpc_custom_dns.py 
/usr/local/lib/python3.6/site-packages/paramiko/transport.py:33: CryptographyDeprecationWarning: Python 3.6 is no longer supported by the Python core team. Therefore, support for it is deprecated in cryptography and will be removed in a future release.
  from cryptography.hazmat.backends import default_backend

==== Marvin Init Started ====

=== Marvin Parse Config Successful ===

=== Marvin Setting TestData Successful===

==== Log Folder Path: /marvin/MarvinLogs/Jun_16_2022_07_07_09_BQCG9M All logs will be available here ====

=== Marvin Init Logging Successful===

==== Marvin Init Successful ====
====Trying SSH Connection: Host:10.0.34.87 User:root                                   Port:22 RetryCnt:60===
===SSH to Host 10.0.34.87 port : 22 SUCCESSFUL===
{Cmd: ssh -i /var/cloudstack/management/.ssh/id_rsa -ostricthostkeychecking=no -oUserKnownHostsFile=/dev/null -p 3922 10.0.36.189 cat /etc/resolv.conf via Host: 10.0.34.87} {returns: ['nameserver 5.5.5.5', 'nameserver 6.6.6.6', 'nameserver 2001:4860:4860::5555', 'nameserver 2001:4860:4860::6666']}
=== TestName: test_01_verify_network_dns | Status : SUCCESS ===

====Trying SSH Connection: Host:10.0.34.87 User:root                                   Port:22 RetryCnt:60===
====Trying SSH Connection: Host:10.0.34.87 User:root                                   Port:22 RetryCnt:60===
===SSH to Host 10.0.34.87 port : 22 SUCCESSFUL===
===SSH to Host 10.0.34.87 port : 22 SUCCESSFUL===
{Cmd: ssh -i /var/cloudstack/management/.ssh/id_rsa -ostricthostkeychecking=no -oUserKnownHostsFile=/dev/null -p 3922 10.0.36.190 cat /etc/resolv.conf via Host: 10.0.34.87} {returns: ['nameserver 5.5.5.5', 'nameserver 6.6.6.6', 'nameserver 2001:4860:4860::5555', 'nameserver 2001:4860:4860::6666']}
{Cmd: ssh -i /var/cloudstack/management/.ssh/id_rsa -ostricthostkeychecking=no -oUserKnownHostsFile=/dev/null -p 3922 10.0.36.190 cat /etc/resolv.conf via Host: 10.0.34.87} {returns: ['nameserver 5.5.5.5', 'nameserver 6.6.6.6', 'nameserver 2001:4860:4860::5555', 'nameserver 2001:4860:4860::6666']}
=== TestName: test_01_verify_vpc_dns | Status : SUCCESS ===

=== Final results are now copied to: /marvin//MarvinLogs/test_network_vpc_custom_dns_2CPKHK ===

Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>

DaanHoogland · 2022-06-03T09:00:54Z

+    public Pair<String, String> getNetworkIp4Dns(final Network network, final DataCenter zone) {
+        String dns1 = null;
+        String dns2 = null;
+        if (org.apache.commons.lang3.StringUtils.isNotEmpty(network.getDns1())) {
+            dns1 = network.getDns1();
+            if (org.apache.commons.lang3.StringUtils.isNotEmpty(network.getDns2())) {
+                dns2 = network.getDns2();
+            }
+        }
+        if (org.apache.commons.lang3.StringUtils.isEmpty(dns1)) {
+            dns1 = zone.getDns1();
+        }
+        if (org.apache.commons.lang3.StringUtils.isEmpty(dns2)) {
+            dns2 = zone.getDns2();
+        }


can we throw an exception if either is dns1 or dns2 still null?

DaanHoogland · 2022-06-03T09:02:14Z

is this open for a review yet @shwstppr ?

shwstppr · 2022-06-03T09:16:47Z

is this open for a review yet @shwstppr ?

@DaanHoogland no, not yet

Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>

acs-robot · 2022-06-06T09:42:17Z

Found UI changes, kicking a new UI QA build
@blueorangutan ui

shwstppr · 2022-06-06T09:42:29Z

@blueorangutan package

blueorangutan · 2022-06-06T09:43:03Z

@shwstppr a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2022-06-06T10:44:42Z

Packaging result: ✔️ el7 ✔️ el8 ✔️ debian ✔️ suse15. SL-JID 3532

Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>

blueorangutan · 2022-08-10T03:33:40Z

Trillian test result (tid-4667)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 36999 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr6425-t4667-kvm-centos7.zip
Smoke tests completed. 101 look OK, 0 have errors
Only failed tests results shown below:

Test	Result	Time (s)	Test File

blueorangutan · 2022-08-10T04:56:54Z

Trillian test result (tid-4668)
Environment: vmware-65u2 (x2), Advanced Networking with Mgmt server 7
Total time taken: 42174 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr6425-t4668-vmware-65u2.zip
Smoke tests completed. 100 look OK, 1 have errors
Only failed tests results shown below:

Test	Result	Time (s)	Test File
test_08_upgrade_kubernetes_ha_cluster	`Failure`	649.66	test_kubernetes_clusters.py

NuxRo

LGTM, good feature!

alexandremattioli · 2022-08-23T12:41:36Z

LGTM

codecov · 2022-08-25T04:41:15Z

Codecov Report

Merging #6425 (c07191e) into main (f76b6c6) will decrease coverage by 0.00%.
The diff coverage is 1.00%.

@@             Coverage Diff              @@
##               main    #6425      +/-   ##
============================================
- Coverage      5.87%    5.87%   -0.01%     
- Complexity     3934     3935       +1     
============================================
  Files          2454     2454              
  Lines        242682   242909     +227     
  Branches      37980    38023      +43     
============================================
+ Hits          14261    14263       +2     
- Misses       226842   227062     +220     
- Partials       1579     1584       +5

Impacted Files	Coverage Δ
...estration/service/NetworkOrchestrationService.java	`100.00% <ø> (ø)`
...tack/engine/orchestration/NetworkOrchestrator.java	`0.00% <0.00%> (ø)`
...src/main/java/com/cloud/network/dao/NetworkVO.java	`21.71% <0.00%> (-1.66%)`	⬇️
...ema/src/main/java/com/cloud/network/vpc/VpcVO.java	`0.00% <0.00%> (ø)`
.../network/vpc/dao/VpcOfferingServiceMapDaoImpl.java	`0.00% <0.00%> (ø)`
.../baremetal/networkservice/BaremetaNetworkGuru.java	`0.00% <0.00%> (ø)`
...bernetes/cluster/KubernetesClusterManagerImpl.java	`0.00% <0.00%> (ø)`
...src/main/java/com/cloud/api/ApiResponseHelper.java	`0.00% <0.00%> (ø)`
.../java/com/cloud/hypervisor/HypervisorGuruBase.java	`3.57% <0.00%> (-0.06%)`	⬇️
...n/java/com/cloud/network/IpAddressManagerImpl.java	`0.00% <0.00%> (ø)`
... and 20 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

acs-robot · 2022-08-25T04:44:13Z

Found UI changes, kicking a new UI QA build
@blueorangutan ui

blueorangutan · 2022-08-25T04:45:03Z

@acs-robot a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

blueorangutan · 2022-08-25T04:51:09Z

UI build: ✔️
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/6425 (SL-JID-2219)

Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>

acs-robot · 2022-08-30T05:45:22Z

Found UI changes, kicking a new UI QA build
@blueorangutan ui

blueorangutan · 2022-08-30T05:46:03Z

@acs-robot a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

shwstppr · 2022-08-30T05:51:13Z

@blueorangutan package

blueorangutan · 2022-08-30T05:51:50Z

UI build: ✔️
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/6425 (SL-JID-2252)

sonarqubecloud · 2022-08-30T06:35:53Z

SonarCloud Quality Gate failed.

0 Bugs
0 Vulnerabilities
0 Security Hotspots
2 Code Smells

0.0% Coverage
2.1% Duplication

shwstppr · 2022-08-30T07:58:47Z

@blueorangutan package

blueorangutan · 2022-08-30T07:59:02Z

@shwstppr a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2022-08-30T09:06:30Z

Packaging result: ✔️ el7 ✔️ el8 ✔️ debian ✔️ suse15. SL-JID 4088

shwstppr · 2022-08-30T09:10:43Z

@blueorangutan test

blueorangutan · 2022-08-30T09:11:03Z

@shwstppr a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

blueorangutan · 2022-08-30T20:04:55Z

Trillian test result (tid-4778)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 37855 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr6425-t4778-kvm-centos7.zip
Smoke tests completed. 101 look OK, 0 have errors
Only failed tests results shown below:

Test	Result	Time (s)	Test File

shwstppr · 2022-09-09T08:34:13Z

@blueorangutan package

blueorangutan · 2022-09-09T08:35:03Z

@shwstppr a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2022-09-09T09:24:36Z

Packaging result: ✖️ el7 ✖️ el8 ✖️ debian ✖️ suse15. SL-JID 4152

blueorangutan · 2022-09-09T10:25:48Z

Packaging result: ✔️ el7 ✔️ el8 ✔️ debian ✔️ suse15. SL-JID 4154

alexandremattioli

LGTM

shwstppr · 2022-09-09T16:30:51Z

@blueorangutan test

blueorangutan · 2022-09-09T16:32:03Z

@shwstppr a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

blueorangutan · 2022-09-10T05:25:03Z

Trillian test result (tid-4856)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 45063 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr6425-t4856-kvm-centos7.zip
Smoke tests completed. 100 look OK, 1 have errors
Only failed tests results shown below:

Test	Result	Time (s)	Test File
test_08_upgrade_kubernetes_ha_cluster	`Failure`	657.86	test_kubernetes_clusters.py

boring-cyborg Bot added component:api component:ipv6 component:kubernetes component:networking component:orchestration component:vpc labels May 31, 2022

apache deleted a comment from blueorangutan Jun 1, 2022

apache deleted a comment from acs-robot Jun 1, 2022

apache deleted a comment from blueorangutan Jun 1, 2022

shwstppr force-pushed the add-network-custom-dns branch from 423359b to af4e23f Compare June 1, 2022 07:57

api,server: custom dns for guest network

ec4efbe

Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>

shwstppr force-pushed the add-network-custom-dns branch from af4e23f to ec4efbe Compare June 1, 2022 08:01

apache deleted a comment from acs-robot Jun 1, 2022

apache deleted a comment from blueorangutan Jun 1, 2022

apache deleted a comment from acs-robot Jun 1, 2022

apache deleted a comment from blueorangutan Jun 1, 2022

wip

78ca1c8

Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>

DaanHoogland reviewed Jun 3, 2022

View reviewed changes

shwstppr added 2 commits June 3, 2022 15:15

refactor

436d1fa

Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>

response and fix

014e715

Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>

nvazquez force-pushed the main branch from c56220f to 0f4c3af Compare June 6, 2022 15:14

shwstppr added 2 commits June 7, 2022 15:36

fix

5876736

Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>

Merge branch 'main' into add-network-custom-dns

2902013

NuxRo approved these changes Aug 22, 2022

View reviewed changes

Merge branch 'main' into add-network-custom-dns

1ea09bf

changes for update network dns

c07191e

Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>

alexandremattioli approved these changes Sep 9, 2022

View reviewed changes

DaanHoogland mentioned this pull request Jan 4, 2023

Revert "Configurable MTU for VR" #7048

Closed

Uh oh!

Conversation

shwstppr commented May 31, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Types of changes

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

Bug Severity

Screenshots (if appropriate):

How Has This Been Tested?

Uh oh!

DaanHoogland Jun 3, 2022

Choose a reason for hiding this comment

Uh oh!

DaanHoogland commented Jun 3, 2022

Uh oh!

shwstppr commented Jun 3, 2022

Uh oh!

acs-robot commented Jun 6, 2022

Uh oh!

shwstppr commented Jun 6, 2022

Uh oh!

blueorangutan commented Jun 6, 2022

Uh oh!

blueorangutan commented Jun 6, 2022

Uh oh!

blueorangutan commented Aug 10, 2022

Uh oh!

blueorangutan commented Aug 10, 2022

Uh oh!

NuxRo left a comment

Choose a reason for hiding this comment

Uh oh!

alexandremattioli commented Aug 23, 2022

Uh oh!

codecov Bot commented Aug 25, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

acs-robot commented Aug 25, 2022

Uh oh!

blueorangutan commented Aug 25, 2022

Uh oh!

blueorangutan commented Aug 25, 2022

Uh oh!

acs-robot commented Aug 30, 2022

Uh oh!

blueorangutan commented Aug 30, 2022

Uh oh!

shwstppr commented Aug 30, 2022

Uh oh!

blueorangutan commented Aug 30, 2022

Uh oh!

sonarqubecloud Bot commented Aug 30, 2022

Uh oh!

shwstppr commented Aug 30, 2022

Uh oh!

blueorangutan commented Aug 30, 2022

Uh oh!

blueorangutan commented Aug 30, 2022

Uh oh!

shwstppr commented Aug 30, 2022

Uh oh!

blueorangutan commented Aug 30, 2022

Uh oh!

blueorangutan commented Aug 30, 2022

Uh oh!

shwstppr commented Sep 9, 2022

Uh oh!

blueorangutan commented Sep 9, 2022

Uh oh!

blueorangutan commented Sep 9, 2022

Uh oh!

blueorangutan commented Sep 9, 2022

Uh oh!

alexandremattioli left a comment

Choose a reason for hiding this comment

Uh oh!

shwstppr commented Sep 9, 2022

shwstppr commented May 31, 2022 •

edited

Loading

codecov Bot commented Aug 25, 2022 •

edited

Loading