Skip to content

Increase size of column 'value' at table 'account_details' #6080

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
shwstppr merged 4 commits into from
Aug 12, 2022
Merged

Increase size of column 'value' at table 'account_details' #6080

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
3853545
Change column `value` size from 255 to 4096 characters, matching the …
GabrielBrascher Mar 9, 2022
19af54e
Fix change column value size for account_details
BartJM Aug 3, 2022
88cd0db
Merge remote-tracking branch 'origin/4.17' into increase-length-in-co…
BartJM Aug 9, 2022
002414e
Move schema change to 4.17.1 upgrade path
BartJM Aug 9, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion api/src/main/java/org/apache/cloudstack/api/command/admin/config/UpdateCfgCmd.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ public class UpdateCfgCmd extends BaseCmd {
@Parameter(name = ApiConstants.NAME, type = CommandType.STRING, required = true, description = "the name of the configuration")
private String cfgName;

@Parameter(name = ApiConstants.VALUE, type = CommandType.STRING, description = "the value of the configuration", length = 4095)
@Parameter(name = ApiConstants.VALUE, type = CommandType.STRING, description = "the value of the configuration", length = 4096)
private String value;

@Parameter(name = ApiConstants.ZONE_ID,
Expand Down
2 changes: 1 addition & 1 deletion engine/schema/src/main/java/com/cloud/user/AccountDetailVO.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ public class AccountDetailVO implements InternalIdentity {
private String name;

@Encrypt
@Column(name = "value")
@Column(name = "value", length=4096)
private String value;

protected AccountDetailVO() {
Expand Down
3 changes: 3 additions & 0 deletions engine/schema/src/main/resources/META-INF/db/schema-41700to41710.sql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -126,3 +126,6 @@ CREATE VIEW `cloud`.`domain_router_view` AS
`cloud`.`async_job` ON async_job.instance_id = vm_instance.id
and async_job.instance_type = 'DomainRouter'
and async_job.job_status = 0;

-- PR #6080 Change column `value` size from 255 to 4096 characters, matching the API "updateConfiguration" "value" size
ALTER TABLE `cloud`.`account_details` MODIFY `value` VARCHAR(4096) NOT NULL;

@Rubueno Rubueno Aug 9, 2022

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@BartJM Can you ensure a newline is present?