Skip to content

ui : Fix linting issue#6023

Merged
nvazquez merged 2 commits into
apache:mainfrom
shapeblue:fix-lint
Feb 22, 2022
Merged

ui : Fix linting issue#6023
nvazquez merged 2 commits into
apache:mainfrom
shapeblue:fix-lint

Conversation

@davidjumani

@davidjumani davidjumani commented Feb 22, 2022

Copy link
Copy Markdown
Contributor

Description

Fixes a linting issue
Also adds the message in its own alert box

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

Screenshot from 2022-02-22 11-58-11

Screenshot from 2022-02-22 12-03-02

@davidjumani

Copy link
Copy Markdown
Contributor Author

@blueorangutan ui

@davidjumani

Copy link
Copy Markdown
Contributor Author

@blueorangutan ui

@blueorangutan

Copy link
Copy Markdown

@davidjumani a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

@blueorangutan

Copy link
Copy Markdown

UI build: ✔️
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/6023 (SL-JID-1169)

@nvazquez nvazquez left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nvazquez
nvazquez merged commit c0fe3dc into apache:main Feb 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

No open projects
Status: Done

Development

Successfully merging this pull request may close these issues.

5 participants