Skip to content

replace Random with SecureRandom#5966

Merged
sureshanaparti merged 1 commit into
apache:4.16from
shapeblue:secureRandomInviteToken
Feb 9, 2022
Merged

replace Random with SecureRandom#5966
sureshanaparti merged 1 commit into
apache:4.16from
shapeblue:secureRandomInviteToken

Conversation

@DaanHoogland

Copy link
Copy Markdown
Contributor

Description

This PR replaces the local var of type Random used for token generation for project invites with a static field of type SecureRandom, making tokens somewhat less predicatable.

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

@DaanHoogland DaanHoogland added this to the 4.16.1.0 milestone Feb 8, 2022
@DaanHoogland

Copy link
Copy Markdown
Contributor Author

@blueorangutan package

@blueorangutan

Copy link
Copy Markdown

@DaanHoogland a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

@blueorangutan

Copy link
Copy Markdown

Packaging result: ✔️ el7 ✔️ el8 ✔️ debian ✔️ suse15. SL-JID 2529

@DaanHoogland

Copy link
Copy Markdown
Contributor Author

@blueorangutan test

@blueorangutan

Copy link
Copy Markdown

@DaanHoogland a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

@blueorangutan

Copy link
Copy Markdown

Trillian test result (tid-3239)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 36591 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr5966-t3239-kvm-centos7.zip
Smoke tests completed. 78 look OK, 2 have errors
Only failed tests results shown below:

Test Result Time (s) Test File
test_01_add_primary_storage_disabled_host Error 0.61 test_primary_storage.py
test_01_primary_storage_nfs Error 0.11 test_primary_storage.py
ContextSuite context=TestStorageTags>:setup Error 0.20 test_primary_storage.py
test_02_upgrade_kubernetes_cluster Failure 376.34 test_kubernetes_clusters.py
test_03_deploy_and_scale_kubernetes_cluster Failure 260.39 test_kubernetes_clusters.py
test_07_deploy_kubernetes_ha_cluster Failure 54.30 test_kubernetes_clusters.py
test_08_upgrade_kubernetes_ha_cluster Failure 33.85 test_kubernetes_clusters.py
test_09_delete_kubernetes_ha_cluster Failure 0.04 test_kubernetes_clusters.py
ContextSuite context=TestKubernetesCluster>:teardown Error 78.21 test_kubernetes_clusters.py

@sureshanaparti sureshanaparti left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code LGTM

@sureshanaparti

Copy link
Copy Markdown
Contributor

@blueorangutan test

@blueorangutan

Copy link
Copy Markdown

@sureshanaparti a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

@GabrielBrascher GabrielBrascher left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick PR, @DaanHoogland!
Code LGTM.

@blueorangutan

Copy link
Copy Markdown

Trillian test result (tid-3256)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 33860 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr5966-t3256-kvm-centos7.zip
Smoke tests completed. 92 look OK, 0 have errors
Only failed tests results shown below:

Test Result Time (s) Test File

@sureshanaparti sureshanaparti changed the title replace Rondom with SecureRandom replace Random with SecureRandom Feb 9, 2022
@sureshanaparti
sureshanaparti merged commit 3fc4ef4 into apache:4.16 Feb 9, 2022
Pearl1594 pushed a commit to shapeblue/cloudstack that referenced this pull request Feb 14, 2022
Co-authored-by: Daan Hoogland <dahn@onecht.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

No open projects
Status: Done

Development

Successfully merging this pull request may close these issues.

5 participants