Skip to content

Add ID search capability to sshkeypairs#5963

Merged
sureshanaparti merged 1 commit into
apache:4.16from
shapeblue:fix-ssh-id
Feb 9, 2022
Merged

Add ID search capability to sshkeypairs#5963
sureshanaparti merged 1 commit into
apache:4.16from
shapeblue:fix-ssh-id

Conversation

@davidjumani

@davidjumani davidjumani commented Feb 8, 2022

Copy link
Copy Markdown
Contributor

Description

This PR adds the search by ID capability to SSH Key pairs to bring it at par with accounts
Also needed as a UI fix

In a 4.16 env, try to view the second / third sshkey. It tries to fetch it by id which does not work and leads to the first keypair always displayed

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)

Feature/Enhancement Scale

  • Major
  • Minor

Screenshots (if appropriate):

(localhost) 🐱 > list sshkeypairs id=5210f701-b13e-4ff7-8aab-eb24ee81526a filter=id,name
{
  "count": 1,
  "sshkeypair": [
    {
      "id": "5210f701-b13e-4ff7-8aab-eb24ee81526a",
      "name": "b"
    }
  ]
}
(localhost) 🐱 > list sshkeypairs filter=id,name
{
  "count": 3,
  "sshkeypair": [
    {
      "id": "d1348275-e203-46bf-a985-45dc2a1b331f",
      "name": "c"
    },
    {
      "id": "5210f701-b13e-4ff7-8aab-eb24ee81526a",
      "name": "b"
    },
    {
      "id": "b4430a09-5b9d-49e4-be55-156e1b7ebd72",
      "name": "a"
    }
  ]
}

@davidjumani
davidjumani requested a review from nvazquez February 8, 2022 10:06
@davidjumani davidjumani added this to the 4.16.1.0 milestone Feb 8, 2022
@davidjumani
davidjumani changed the base branch from main to 4.16 February 8, 2022 10:06
@davidjumani

Copy link
Copy Markdown
Contributor Author

@blueorangutan package

@blueorangutan

Copy link
Copy Markdown

@davidjumani a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

@blueorangutan

Copy link
Copy Markdown

Packaging result: ✖️ el7 ✔️ el8 ✖️ debian ✔️ suse15. SL-JID 2519

@weizhouapache

Copy link
Copy Markdown
Member

@blueorangutan package

@blueorangutan

Copy link
Copy Markdown

@weizhouapache a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

@blueorangutan

Copy link
Copy Markdown

Packaging result: ✖️ el7 ✖️ el8 ✖️ debian ✖️ suse15. SL-JID 2523

@davidjumani

Copy link
Copy Markdown
Contributor Author

@blueorangutan package

@blueorangutan

Copy link
Copy Markdown

@davidjumani a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

@blueorangutan

Copy link
Copy Markdown

Packaging result: ✔️ el7 ✔️ el8 ✔️ debian ✔️ suse15. SL-JID 2526

@weizhouapache weizhouapache left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested ok

@davidjumani

Copy link
Copy Markdown
Contributor Author

@blueorangutan test

@blueorangutan

Copy link
Copy Markdown

@davidjumani a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

@DaanHoogland DaanHoogland left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cltgm

@blueorangutan

Copy link
Copy Markdown

Trillian test result (tid-3234)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 32976 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr5963-t3234-kvm-centos7.zip
Smoke tests completed. 92 look OK, 0 have errors
Only failed tests results shown below:

Test Result Time (s) Test File

@sureshanaparti
sureshanaparti merged commit 453aeb0 into apache:4.16 Feb 9, 2022
@davidjumani
davidjumani deleted the fix-ssh-id branch February 9, 2022 04:55
Pearl1594 pushed a commit to shapeblue/cloudstack that referenced this pull request Feb 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

No open projects
Status: Done

Development

Successfully merging this pull request may close these issues.

6 participants