Skip to content

ui: fix related key for section#5929

Merged
sureshanaparti merged 1 commit into
apache:4.16from
shapeblue:fix-ui-domain-accounts-button
Feb 4, 2022
Merged

ui: fix related key for section#5929
sureshanaparti merged 1 commit into
apache:4.16from
shapeblue:fix-ui-domain-accounts-button

Conversation

@shwstppr

@shwstppr shwstppr commented Feb 3, 2022

Copy link
Copy Markdown
Contributor

Description

Pass related key of section to route
Fixes #5928

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

Screenshot from 2022-02-03 17-07-32

Fixes apache#5928

Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
@shwstppr

shwstppr commented Feb 3, 2022

Copy link
Copy Markdown
Contributor Author

@blueorangutan ui

@blueorangutan

Copy link
Copy Markdown

@shwstppr a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

@blueorangutan

Copy link
Copy Markdown

UI build: ✔️
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/5929 (SL-JID-1089)

@sureshanaparti sureshanaparti added this to the 4.16.1.0 milestone Feb 3, 2022
@sureshanaparti sureshanaparti linked an issue Feb 3, 2022 that may be closed by this pull request

@DaanHoogland DaanHoogland left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code looks good
tested in qa... works

@GabrielBrascher GabrielBrascher left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM

@sureshanaparti sureshanaparti left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified. LGTM.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

No open projects
Status: Done

Development

Successfully merging this pull request may close these issues.

UI - Missing view Accounts button in domain view

5 participants