network: update ip in lb/pf/dnat tables when update vm nic ip by weizhouapache · Pull Request #5757 · apache/cloudstack

weizhouapache · 2021-12-08T13:27:32Z

Description

This PR fixes the issue that new ip is not working if old ip is used in lb/pf (or dnat).

Steps to reproduce the issue
(1) create isolated network, and vm
(2) acquire 3 public ips, add firewall rules to allow port 22 (ssh)
(3) create NAT to the vm on public ip 1, load balancer to vm port 22 (ssh) on public ip 2, port forwarding rule to vm port 22 on public ip 3
(4) verify the ssh connection to vm, all work
(5) stop vm, and update vm nic ip, start vm
(6) expected result: DNAT, LB, PF work,
actual result without this PR : LB and PF do not work.

Types of changes

Breaking change (fix or feature that would cause existing functionality to change)
New feature (non-breaking change which adds functionality)
Bug fix (non-breaking change which fixes an issue)
Enhancement (improves an existing feature and functionality)
Cleanup (Code refactoring and cleanup, that may add test cases)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

Major
Minor

Bug Severity

Screenshots (if appropriate):

How Has This Been Tested?

weizhouapache · 2021-12-08T14:22:58Z

@blueorangutan package

blueorangutan · 2021-12-08T14:24:03Z

@weizhouapache a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

blueorangutan · 2021-12-08T15:10:36Z

Packaging result: ✔️ el7 ✔️ el8 ✔️ debian ✔️ suse15. SL-JID 1863

weizhouapache · 2021-12-08T15:11:12Z

@blueorangutan test

blueorangutan · 2021-12-08T23:54:31Z

Trillian test result (tid-2642)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 29970 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr5757-t2642-kvm-centos7.zip
Smoke tests completed. 91 look OK, 0 have errors
Only failed tests results shown below:

Test	Result	Time (s)	Test File

weizhouapache · 2021-12-09T10:30:35Z

@blueorangutan package

blueorangutan · 2021-12-09T10:35:04Z

@weizhouapache a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

blueorangutan · 2021-12-09T11:17:27Z

Packaging result: ✔️ el7 ✔️ el8 ✔️ debian ✔️ suse15. SL-JID 1868

weizhouapache · 2021-12-09T12:09:56Z

@blueorangutan test

blueorangutan · 2021-12-09T12:12:04Z

@weizhouapache a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

DaanHoogland

clgtm, tnx @weizhouapache

blueorangutan · 2021-12-09T21:13:38Z

Trillian test result (tid-2644)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 31177 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr5757-t2644-kvm-centos7.zip
Smoke tests completed. 91 look OK, 0 have errors
Only failed tests results shown below:

Test	Result	Time (s)	Test File

GutoVeronezi

@weizhouapache I think it would be nice if we add some unit tests to these new methods.

weizhouapache · 2021-12-23T08:24:57Z

@blueorangutan package

blueorangutan · 2021-12-23T08:26:03Z

@weizhouapache a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

blueorangutan · 2021-12-23T09:31:14Z

Packaging result: ✖️ el7 ✔️ el8 ✖️ debian ✔️ suse15. SL-JID 1998

sureshanaparti · 2021-12-23T09:51:21Z

@blueorangutan package

blueorangutan · 2021-12-23T09:55:03Z

@sureshanaparti a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

blueorangutan · 2021-12-23T11:08:40Z

Packaging result: ✖️ el7 ✖️ el8 ✔️ debian ✔️ suse15. SL-JID 2002

weizhouapache · 2021-12-23T12:02:15Z

@blueorangutan package

blueorangutan · 2021-12-23T12:03:04Z

@weizhouapache a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

weizhouapache · 2021-12-23T13:11:16Z

@blueorangutan package

blueorangutan · 2021-12-23T13:12:03Z

@weizhouapache a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

blueorangutan · 2021-12-23T13:25:03Z

Packaging result: ✖️ el7 ✖️ el8 ✖️ debian. SL-JID 2005

blueorangutan · 2021-12-23T14:01:28Z

Packaging result: ✔️ el7 ✔️ el8 ✔️ debian ✔️ suse15. SL-JID 2009

weizhouapache · 2021-12-23T15:12:22Z

@blueorangutan test

blueorangutan · 2021-12-23T15:13:03Z

@weizhouapache a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

blueorangutan · 2021-12-24T01:15:11Z

Trillian test result (tid-2734)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 34691 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr5757-t2734-kvm-centos7.zip
Smoke tests completed. 90 look OK, 0 have errors
Only failed tests results shown below:

Test	Result	Time (s)	Test File

GutoVeronezi

CLGTM

I'm just missing some unit tests.

…same domain (#5769) * Enhancement: create Shared networks and VPC private gateways by users * UI bug fix: pass correct domainid in CreateSharedNetworkForm * Update #5730: fix test failure with test_guest_vlan_range.py * Update #5730: fix test failure with test_persistent_network.py * Update #5730: Add since to new API commands and API parameters * Update #5730: Get first physical network for VPC private gateway if other ways do not work * Update #5730: code optimization (return !offering.isSpecifyVlan()) * Update #5730: fix hard-coded network offering id in test_pvlan.py * Update #5730: skip access check on the network owner if the owner is ROOT/system * Update #5730: overlap check on cidr/startip/endip * Update #5730: add methods to get accountid/domainid of shared networks * Update #5730: improve integration tests * Update #5730: update as per GutoVeronezi's comments * Network Sharing: give network access permission to other accounts within a domain * network: update ip in lb/pf/dnat tables when update vm nic ip * Update #5757: create 3 separated methods for DNAT/LB/PF update * travis: install python3-setuptools * Network Sharing: update integration test * Update #5769: Remove NetworkPermission.Ops * Update #5769: Update as per Daan's comments * Update #5769: Update as per Suresh's comments * Update #5769: fix UI bug that accounts/projects are not listed * Update #5769: fix domain admin can deploy vm on L2 network of other users * Update #5769: Remove method listPermittedNetworkIdsByDomains in NetworkPermissionDao * Update #5769: Skip network operation permissions check for root admin * UI: fix create Isolated/L2 network form * Update #5730: fix create Shared network form * Update #5769: fix domain admin can deploy vm on L2 network of other users * test: fix test_storage_policy.py * Update #5769: fix remove_nic in test_network_permissions.py * Update #5769: extract some codes to a method * Update #5769: fix add/remove nic by domain admin * Update #5769: allow domain admin to enable/disable static nat and create port forwarding rules * Update #5769: update integration test * Update #5769: fix unit test AssignLoadBalancerTest.java * Update #5769: allow normal users to share network permission to other users on UI * Update #5769: fix small UI bug with label * Update #5769: Support L2 network as associated network * test: sleep 30s after restarting mgt server in test_kubernetes_supported_versions.py to fix test failures with test_secondary_storage.py * Update #5784: revert part of changes in #2420 * Update #5757: invert if condition to reduce code indentation * Update #5769: fix regular user cannot create L2 network * Update #5769: Add associated nework id and name in private gateway response * Update #5769: list networks by networkfilter=Account on UI * Update #5769: fix ui issue when list private gateways or create shared network if no isolated networks * Update #5769: fix vue ui warnings * Update #5679: add BaseResponseWithAssociatedNetwork and extract method setResponseAssociatedNetworkInformation * Update #5679: extract some methods in VpcManagerImpl.java * Update #5679: Update smoke tests as per Daan's comments * Update #5769: fix vpc with private gateways cannot be removed when remove an acount * Update #5769: fix unit test failures after merging latest main * Update #5769: fix schema-41610to41700.sql * Update #5769: fix Request failed due to empty network offering list on UI * Update #5769: Throw exception when account is not found by name * Update #5769: display a warning message if network offering list is empty * Update #5769: fix an UI bug caused by previous commit b286cb7 * Update #5769: fix UI bugs due to vue3 merge * Update #5769: fix issue due to account type refactoring * Update #5769: fix ui bugs due to vue3 * Update #5769: fix issue due to vue3 upgrade * Update #5769: fix issue due to vue3 upgrade part 2 * Update #5769: fix issue due to vue3 upgrade part 3 * Update #5769: highlight default scope when create shared network on UI * Update #5769: fix domain list is not loaded on UI * Update #5769: fix restart/delete shared network by normal users * Update #5769: fix restart domain-scope shared network by domain admin * Update #5769: fix 3 UI bugs (1) double networks in list; (2) icon of first items in list; (3) account/project autoselect * Update #5769: fix 2 ui bugs; (1) selected project is not changed when change domain; (2) no network should be selected by default * Update #5769: fix update shared networks by domain admin/regular user * Update #5769: fix Flicking warning message about the empty network offerings * Update #5769: display associated network name in shared network info card * Update #5769: fix create private gateway form * Update #5769: fix network lists in project view * Update #5769: fix duplicated networks in network dropdown * Update #5769: fix failed to create shared network if associated L2 network is Setup * Update #5769: check AccessType.OperateEntry on network in its implementation * Revert "Update #5769: check AccessType.OperateEntry on network in its implementation" This reverts commit c42c489. * Update #5769: fix keyword search in list guest vlans

network: update ip in lb/pf/dnat tables when update vm nic ip

f80aac7

weizhouapache force-pushed the 4.16-fix-update-vm-nic branch from 3115a2d to f80aac7 Compare December 8, 2021 14:07

apache deleted a comment from blueorangutan Dec 8, 2021

DaanHoogland reviewed Dec 9, 2021

View reviewed changes

Comment thread server/src/main/java/com/cloud/vm/UserVmManagerImpl.java Outdated

Update apache#5757: create 3 separated methods for DNAT/LB/PF update

7b3bc94

DaanHoogland approved these changes Dec 9, 2021

View reviewed changes

sureshanaparti added this to the 4.16.1.0 milestone Dec 13, 2021

weizhouapache added a commit to shapeblue/cloudstack that referenced this pull request Dec 13, 2021

Update apache#5757: create 3 separated methods for DNAT/LB/PF update

fefbc3c

sureshanaparti reviewed Dec 14, 2021

View reviewed changes

Comment thread server/src/main/java/com/cloud/vm/UserVmManagerImpl.java

sureshanaparti approved these changes Dec 14, 2021

View reviewed changes

GutoVeronezi reviewed Dec 21, 2021

View reviewed changes

Comment thread server/src/main/java/com/cloud/vm/UserVmManagerImpl.java Outdated

Comment thread server/src/main/java/com/cloud/vm/UserVmManagerImpl.java Outdated

Comment thread server/src/main/java/com/cloud/vm/UserVmManagerImpl.java Outdated

Update apache#5757: invert if condition to reduce code indentation

a15d69b

apache deleted a comment from blueorangutan Dec 22, 2021

sureshanaparti added the component:networking label Dec 23, 2021

apache deleted a comment from weizhouapache Dec 23, 2021

apache deleted a comment from blueorangutan Dec 23, 2021

apache deleted a comment from weizhouapache Dec 23, 2021

apache deleted a comment from blueorangutan Dec 23, 2021

apache deleted a comment from sureshanaparti Dec 23, 2021

weizhouapache added a commit to shapeblue/cloudstack that referenced this pull request Dec 23, 2021

Update apache#5757: invert if condition to reduce code indentation

14153b4

sureshanaparti requested a review from GutoVeronezi December 24, 2021 05:24

GutoVeronezi approved these changes Dec 27, 2021

View reviewed changes

sureshanaparti merged commit 7823868 into apache:4.16 Dec 27, 2021

weizhouapache deleted the 4.16-fix-update-vm-nic branch December 9, 2022 08:34

Uh oh!

Conversation

weizhouapache commented Dec 8, 2021

Description

Types of changes

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

Bug Severity

Screenshots (if appropriate):

How Has This Been Tested?

Uh oh!

weizhouapache commented Dec 8, 2021

Uh oh!

blueorangutan commented Dec 8, 2021

Uh oh!

blueorangutan commented Dec 8, 2021

Uh oh!

weizhouapache commented Dec 8, 2021

Uh oh!

blueorangutan commented Dec 8, 2021

Uh oh!

Uh oh!

weizhouapache commented Dec 9, 2021

Uh oh!

blueorangutan commented Dec 9, 2021

Uh oh!

blueorangutan commented Dec 9, 2021

Uh oh!

weizhouapache commented Dec 9, 2021

Uh oh!

blueorangutan commented Dec 9, 2021

Uh oh!

DaanHoogland left a comment

Choose a reason for hiding this comment

Uh oh!

blueorangutan commented Dec 9, 2021

Uh oh!

Uh oh!

GutoVeronezi left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

weizhouapache commented Dec 23, 2021

Uh oh!

blueorangutan commented Dec 23, 2021

Uh oh!

blueorangutan commented Dec 23, 2021

Uh oh!

sureshanaparti commented Dec 23, 2021

Uh oh!

blueorangutan commented Dec 23, 2021

Uh oh!

blueorangutan commented Dec 23, 2021

Uh oh!

weizhouapache commented Dec 23, 2021

Uh oh!

blueorangutan commented Dec 23, 2021

Uh oh!

weizhouapache commented Dec 23, 2021

Uh oh!

blueorangutan commented Dec 23, 2021

Uh oh!

blueorangutan commented Dec 23, 2021

Uh oh!

blueorangutan commented Dec 23, 2021

Uh oh!

weizhouapache commented Dec 23, 2021

Uh oh!

blueorangutan commented Dec 23, 2021

Uh oh!

blueorangutan commented Dec 24, 2021

Uh oh!

GutoVeronezi left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

GutoVeronezi left a comment •

edited

Loading