Skip to content

Removed sensitive info from UI when volume attach/detach fails #4476

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
yadvr merged 2 commits into from
Nov 18, 2020
Merged

Removed sensitive info from UI when volume attach/detach fails #4476

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
66e3e52
Removed sensitive info from UI when attach/detach fails
Spaceman1984 Nov 18, 2020
62ce2dc
minor formatting change
Spaceman1984 Nov 18, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions ...s/hypervisors/vmware/src/main/java/com/cloud/storage/resource/VmwareStorageProcessor.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2248,15 +2248,16 @@ private Answer attachVolume(Command cmd, DiskTO disk, boolean isAttach, boolean
String msg = "";

if (isAttach) {
msg += "Failed to attach volume: " + e.getMessage();
msg += "Failed to attach volume: ";
}
else {
msg += "Failed to detach volume: " + e.getMessage();
msg += "Failed to detach volume: ";
}

s_logger.error(msg, e);
s_logger.error(msg + e.getMessage(), e);

return new AttachAnswer(msg);
// Sending empty error message - too many duplicate errors in UI
return new AttachAnswer("");
}
}

Expand Down