Fixed VM scaling test on Xenserver by Spaceman1984 · Pull Request #4443 · apache/cloudstack

Spaceman1984 · 2020-11-05T08:06:27Z

Description

If a VM is started before setting the global var enable.dynamic.scale.vm to true, scaling is not possible on the specific VM until it is stopped and started again. Setting the global var before starting the VM solves the problem. The template also needs dynamic scaling enabled. But after checking those variables the VM instance would still fail due to the default max vCPUs being set to 16.

Fixes: #4237

Types of changes

Breaking change (fix or feature that would cause existing functionality to change)
New feature (non-breaking change which adds functionality)
Bug fix (non-breaking change which fixes an issue)
Enhancement (improves an existing feature and functionality)
Cleanup (Code refactoring and cleanup, that may add test cases)

Screenshots (if appropriate):

How Has This Been Tested?

Run the Marvin test - scaling works fine.

Spaceman1984 · 2020-11-05T08:08:37Z

@blueorangutan package

blueorangutan · 2020-11-05T08:09:10Z

@Spaceman1984 a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

blueorangutan · 2020-11-05T08:43:20Z

Packaging result: ✔centos7 ✔centos8 ✔debian. JID-2335

Spaceman1984 · 2020-11-05T08:56:18Z

@blueorangutan test ?

Spaceman1984 · 2020-11-05T09:04:26Z

@blueorangutan test centos7 xcpng76

blueorangutan · 2020-11-05T09:05:04Z

@Spaceman1984 a Trillian-Jenkins test job (centos7 mgmt + xcpng76) has been kicked to run smoke tests

blueorangutan · 2020-11-05T19:46:16Z

Trillian test result (tid-3129)
Environment: xcpng76 (x2), Advanced Networking with Mgmt server 7
Total time taken: 36731 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4443-t3129-xcpng76.zip
Intermittent failure detected: /marvin/tests/smoke/test_kubernetes_clusters.py
Intermittent failure detected: /marvin/tests/smoke/test_scale_vm.py
Smoke tests completed. 85 look OK, 1 have error(s)
Only failed tests results shown below:

Test	Result	Time (s)	Test File
test_01_scale_vm	`Failure`	9.32	test_scale_vm.py

Spaceman1984 · 2020-11-05T20:36:36Z

Needs more investigation

… host

Spaceman1984 · 2020-11-11T09:30:50Z

@blueorangutan package

blueorangutan · 2020-11-11T09:31:21Z

@Spaceman1984 a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

Spaceman1984 · 2020-11-11T09:41:09Z

Changing to milestone 4.16 as per #4447

blueorangutan · 2020-11-11T10:13:18Z

Packaging result: ✔centos7 ✔centos8 ✔debian. JID-2364

Spaceman1984 · 2020-11-11T14:35:56Z

@blueorangutan package

Spaceman1984 · 2020-11-12T07:10:48Z

@blueorangutan package

blueorangutan · 2020-11-12T07:11:24Z

@Spaceman1984 a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

blueorangutan · 2020-11-12T07:44:23Z

Packaging result: ✔centos7 ✔centos8 ✔debian. JID-2372

Spaceman1984 · 2020-11-12T08:06:48Z

@blueorangutan test centos7 xcpng76

blueorangutan · 2020-11-12T08:07:24Z

@Spaceman1984 a Trillian-Jenkins test job (centos7 mgmt + xcpng76) has been kicked to run smoke tests

blueorangutan · 2020-11-12T17:44:14Z

Trillian test result (tid-3159)
Environment: xcpng76 (x2), Advanced Networking with Mgmt server 7
Total time taken: 32666 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4443-t3159-xcpng76.zip
Intermittent failure detected: /marvin/tests/smoke/test_scale_vm.py
Intermittent failure detected: /marvin/tests/smoke/test_host_maintenance.py
Smoke tests completed. 85 look OK, 1 have error(s)
Only failed tests results shown below:

Test	Result	Time (s)	Test File
test_01_scale_vm	`Failure`	11.43	test_scale_vm.py

Spaceman1984 · 2020-11-13T07:32:43Z

Something else is still wrong.

yadvr · 2021-02-18T08:27:04Z

@Spaceman1984 any update on this?

Spaceman1984 · 2021-02-18T08:34:38Z

No update, I haven't looked into this since November, I will have to reinvestigate.

Spaceman1984 · 2021-02-24T07:01:32Z

@blueorangutan test centos7 xcpng76

blueorangutan · 2021-02-24T07:02:11Z

@Spaceman1984 a Trillian-Jenkins test job (centos7 mgmt + xcpng76) has been kicked to run smoke tests

yadvr · 2021-04-27T05:02:31Z

Fixed by #4929, closing this.

BenoitLair · 2022-04-25T12:42:46Z

Hello @rohityadavcloud
We still have this issue with ACS 4.16.0 and Xcp-NG 8.2

Could it be possible to have a fix or a tweak to allow bypass "memory-static-max" constraint violation moreover of the xen max vcpu ?

Added global var before scaling VM

7e2f532

Spaceman1984 changed the title ~~Added global var before scaling VM~~ Enabled dynamic scaling before starting a VM for Marvin VM scaling test Nov 5, 2020

Spaceman1984 changed the title ~~Enabled dynamic scaling before starting a VM for Marvin VM scaling test~~ Enabled dynamic scaling before starting a VM for Marvin VM scaling test on Xenserver Nov 5, 2020

Spaceman1984 marked this pull request as draft November 5, 2020 20:36

yadvr added this to the 4.15.0.0 milestone Nov 6, 2020

DaanHoogland added component:XenServer type:bug labels Nov 6, 2020

ACSGitBot added the status:work-in-progress label Nov 8, 2020

DaanHoogland added the Severity:Minor label Nov 10, 2020

Spaceman1984 mentioned this pull request Nov 11, 2020

Fixed failed to start instances on Xenserver with dynamic scaling due to default max cpus. #4447

Closed

5 tasks

Preventing failed instance due to specifying more vCPUs than pCPUs on…

a479256

… host

DaanHoogland reviewed Nov 11, 2020

View reviewed changes

Comment thread plugins/hypervisors/xenserver/src/main/java/com/cloud/hypervisor/XenServerGuru.java Outdated

Spaceman1984 modified the milestones: 4.15.0.0, 4.16.0.0 Nov 11, 2020

Moved logic to method

fc75399

Spaceman1984 changed the title ~~Enabled dynamic scaling before starting a VM for Marvin VM scaling test on Xenserver~~ Fixed VM scaling test on Xenserver Nov 11, 2020

Spaceman1984 marked this pull request as ready for review November 11, 2020 14:39

Spaceman1984 marked this pull request as draft November 13, 2020 07:32

yadvr closed this Apr 27, 2021

Uh oh!

Conversation

Spaceman1984 commented Nov 5, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Types of changes

Screenshots (if appropriate):

How Has This Been Tested?

Uh oh!

Spaceman1984 commented Nov 5, 2020

Uh oh!

blueorangutan commented Nov 5, 2020

Uh oh!

blueorangutan commented Nov 5, 2020

Uh oh!

Spaceman1984 commented Nov 5, 2020

Uh oh!

Spaceman1984 commented Nov 5, 2020

Uh oh!

blueorangutan commented Nov 5, 2020

Uh oh!

blueorangutan commented Nov 5, 2020

Uh oh!

Spaceman1984 commented Nov 5, 2020

Uh oh!

Spaceman1984 commented Nov 11, 2020

Uh oh!

blueorangutan commented Nov 11, 2020

Uh oh!

Uh oh!

Spaceman1984 commented Nov 11, 2020

Uh oh!

blueorangutan commented Nov 11, 2020

Uh oh!

Spaceman1984 commented Nov 11, 2020

Uh oh!

Spaceman1984 commented Nov 12, 2020

Uh oh!

blueorangutan commented Nov 12, 2020

Uh oh!

blueorangutan commented Nov 12, 2020

Uh oh!

Spaceman1984 commented Nov 12, 2020

Uh oh!

blueorangutan commented Nov 12, 2020

Uh oh!

blueorangutan commented Nov 12, 2020

Uh oh!

Spaceman1984 commented Nov 13, 2020

Uh oh!

yadvr commented Feb 18, 2021

Uh oh!

Spaceman1984 commented Feb 18, 2021

Uh oh!

Spaceman1984 commented Feb 24, 2021

Uh oh!

blueorangutan commented Feb 24, 2021

Uh oh!

yadvr commented Apr 27, 2021

Uh oh!

BenoitLair commented Apr 25, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Spaceman1984 commented Nov 5, 2020 •

edited

Loading