Install python-dnspython or python-dns to fix issue with cloudstack-setup-management

[ustcweizhou]

Description

Fixes #3817 #3841

Types of changes

• Breaking change (fix or feature that would cause existing functionality to change)
• New feature (non-breaking change which adds functionality)
• Bug fix (non-breaking change which fixes an issue)
• Enhancement (improves an existing feature and functionality)
• Cleanup (Code refactoring and cleanup, that may add test cases)

Screenshots (if appropriate):

How Has This Been Tested?

[DaanHoogland]

lgtm, but i think we want this on 4.13

[weizhouapache]

lgtm, but i think we want this on 4.13

yes, we do need.
After this get merged, I will create another PR , so we do not need to avoid review twice.

[GabrielBrascher]

@DaanHoogland @ustcweizhou it might be easier to target this one into 4.13 and then forward it to 4.14, instead of opening two PRs. What do you think of targeting this PR to 4.13?

[DaanHoogland]

I agree with @GabrielBrascher , @weizhouapache. i've been forward merging all 4.13 PRs so far, so we only review once.

[weizhouapache]

@DaanHoogland @GabrielBrascher
I understand your concerns.
due to #3371 which only exist in master not 4.13, there are some conflicts when forward merge 4.13 to master if this PR is merged into 4.13

@DaanHoogland can you cherry pick #3371 from master to 4.13 ?

[DaanHoogland]

ohw, that is a revert and a revert of a revert... will have a look @weizhouapache , but you might be right.

[DaanHoogland]

the conflict are the deps 'gawk, iproute2', I have no idea if these are needed in 4.13. Need to look so procrastinating....

[weizhouapache]

the conflict are the deps 'gawk, iproute2', I have no idea if these are needed in 4.13. Need to look so procrastinating....

oh, yes, this commit e93f6bf only exist in master

[DaanHoogland]

tnx @weizhouapache. @rhtyd @GabrielBrascher I can cherry pick both those commits without conflicts: e93f6bf and a0efbf9 . Shall we and than ask @weizhouapache to base this on 4.13 and run regression?
/cc @andrijapanicsb

[svenvogel]

@DaanHoogland a0efbf9 and e93f6bf <- does this has an affect on the current PR or do you want to cherry pick it for dependency?

[yadvr]

@ustcweizhou can you simply close this and open a PR against 4.13 including the changes to add/support gawk and iproute2 dependencies?

[yadvr]

Ping @ustcweizhou ?

[weizhouapache]

rebased with 4.13 instead of master

[yadvr]

@ustcweizhou can you also check in 4.13, the changes in centos6's spec?
@blueorangutan package

[blueorangutan]

@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

[blueorangutan]

Packaging result: ✖centos6 ✔centos7 ✔debian. JID-750

[weizhouapache]

@ustcweizhou can you also check in 4.13, the changes in centos6's spec?
@blueorangutan package

@rhtyd do we still support centos6 ? I do not have a centos6 env

[blueorangutan]

@weizhouapache a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

[blueorangutan]

Packaging result: ✖centos6 ✔centos7 ✔debian. JID-754

[yadvr]

@ustcweizhou in master/4.14 we won't but in 4.13 we still support centos6 (see packaging/centos63/ in your 4.13 branch)

[weizhouapache]

@rhtyd
python-pip and python-dns are part of EPEL for centos6
I would suggest to add the fix in cloudstack document

sudo yum install epel-release
sudo yum -y install python-dns

[yadvr]

Sure @ustcweizhou cc @andrijapanicsb @DaanHoogland

[DaanHoogland]

@rhtyd @weizhouapache are we merging this as is?

[weizhouapache]

@rhtyd @weizhouapache are we merging this as is?

I am ok with it.
but you know, I am the author of this PR .....

[yadvr]

I'm okay with doc notes. @ustcweizhou please send a PR to apache/cloudstack-documentation or @andrijapanicsb please keep a note. Thanks.

[yadvr]

Checked the centos7 dependencies names are correct, packaging is OK. Explicit smoketests are not necessary.