Skip to content

systemvm: for ip route show command don't use the throw command#3612

Merged
yadvr merged 1 commit into
apache:4.13from
shapeblue:vr-route-show-fix
Nov 11, 2019
Merged

systemvm: for ip route show command don't use the throw command#3612
yadvr merged 1 commit into
apache:4.13from
shapeblue:vr-route-show-fix

Conversation

@yadvr

@yadvr yadvr commented Sep 30, 2019

Copy link
Copy Markdown
Member

While searching for existing route, don't use the throw keyword when
using the cmd with ip route show. This fixes unnecessary ERROR messages in the VR cloud.log and issue of re-adding an already added routing rule (which may throw RTLINK file already exists error).

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)

While searching for existing route, don't use the throw keyword when
using the cmd with `ip route show`.

Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
@yadvr

yadvr commented Sep 30, 2019

Copy link
Copy Markdown
Member Author

@blueorangutan package

@blueorangutan

Copy link
Copy Markdown

@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

@blueorangutan

Copy link
Copy Markdown

Packaging result: ✔centos6 ✔centos7 ✔debian. JID-301

@yadvr

yadvr commented Sep 30, 2019

Copy link
Copy Markdown
Member Author

@blueorangutan test

@blueorangutan

Copy link
Copy Markdown

@rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

@blueorangutan

Copy link
Copy Markdown

Trillian test result (tid-395)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 29386 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr3612-t395-kvm-centos7.zip
Smoke tests completed. 77 look OK, 0 have error(s)
Only failed tests results shown below:

Test Result Time (s) Test File

@yadvr

yadvr commented Oct 22, 2019

Copy link
Copy Markdown
Member Author

Can you review this @ustcweizhou ? Thanks.

@yadvr
yadvr requested review from andrijapanicsb and removed request for andrijapanicsb October 22, 2019 09:31
@ustcweizhou

Copy link
Copy Markdown
Contributor

LGTM
tested in vpc, no issues.

@yadvr

yadvr commented Oct 23, 2019

Copy link
Copy Markdown
Member Author

@andrijapanicsb can you review? this is the bug that cause errors in the /var/log/cloud.log for a VR when it runs command to show/check if a route exists (doesn't actually cause any VR issues/failure, but causes errors in the log)

@yadvr

yadvr commented Nov 11, 2019

Copy link
Copy Markdown
Member Author

@andrijapanicsb can you review this? Thanks.

@andrijapanicsb andrijapanicsb left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - tested manually, and the specific error is not there.

@yadvr
yadvr merged commit ae61bfe into apache:4.13 Nov 11, 2019
@yadvr yadvr modified the milestones: 4.13.1.0, 4.14.0.0 Nov 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants