server: fix public IP addresses filtering#3368
Conversation
Added missing parameter in listPublicIpAddresses API. Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
|
@blueorangutan package |
|
@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. |
|
Packaging result: ✔centos6 ✔centos7 ✔debian. JID-2825 |
|
@blueorangutan test |
|
@rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests |
|
Trillian test result (tid-3630)
|
yadvr
changed the title
| sb.and("physicalNetworkId", sb.entity().getPhysicalNetworkId(), SearchCriteria.Op.EQ); | ||
| sb.and("associatedNetworkIdEq", sb.entity().getAssociatedWithNetworkId(), SearchCriteria.Op.EQ); | ||
| sb.and("associatedNetworkId", sb.entity().getAssociatedWithNetworkId(), SearchCriteria.Op.EQ); | ||
| sb.and("sourceNetworkId", sb.entity().getSourceNetworkId(), SearchCriteria.Op.EQ); |
There was a problem hiding this comment.
@shwstppr any reason why sourceNetworkId is chosen instead of networkId parameter?
6 participants
Description
Fixes #3295
listPublicIPAddresses API was missing networkid parameter and it has been used in UI to list public IP addresses while changing IP address for a VM.
networkid parameter is added to listPublicIPAddresses API which would allow filtering public IP addresses based on the source network. This will help to show relevant IP addresses when users try to change assigned IP address for a VM NIC.
Types of changes
Screenshots (if appropriate):
How Has This Been Tested?
UI and cmk