ui: added missing hypervisor options for upload template#3367
Merged
yadvr merged 2 commits intoJun 5, 2019
Conversation
Upload template form was missing some hypervisor specific options which can be seen on Register template form. For XenServer, XenServer tool version added For VMware, Root disk controller, NIC adapter type, Keyboard type added and HVM is hidden For KVM, Root disk controller added Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
yadvr
approved these changes
May 31, 2019
5 tasks
anuragaw
approved these changes
Jun 3, 2019
anuragaw
left a comment
anuragaw
left a comment
Contributor
There was a problem hiding this comment.
LGTM
Haven't tested each Hypervisor upload but based on snapshots and pure JS changes.
DaanHoogland
reviewed
Jun 3, 2019
DaanHoogland
left a comment
DaanHoogland
left a comment
Contributor
There was a problem hiding this comment.
can you extend or refactor your use of the word 'only' in the comments, please? The phrase "fields for hypervisor == ..." makes more sense and in other places maybe "field-visibility for hyporvisor == ...".
nvazquez
approved these changes
Jun 3, 2019
Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
yadvr
changed the title
Member
|
Purely JS/UI change, merged based on screenshots and reviews. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Upload template form was missing some hypervisor specific options which can be seen on Register template form.
For XenServer, XenServer tool version added
For VMware, Root disk controller, NIC adapter type, Keyboard type added and HVM is hidden
For KVM, Root disk controller added
Fixes #3363
Types of changes
Screenshots (if appropriate):
How Has This Been Tested?