server: export granular volume bytes and iops metrics by yadvr · Pull Request #3259 · apache/cloudstack

yadvr · 2019-04-04T10:44:32Z

Problem: The VM metrics has aggregated volume bytes read/write and iops metrics but not on per volume basis.
Root Cause: The volume stats sub-system is not used to export the metrics, the support is not available for VMware.
Solution: Use the volume stats sub-system and DB table to export the metrics via the listVolumes and listVolumeMetrics API, and implement support for VMware and fix issue with network and disk metrics in the VM metrics view.

Types of changes

Breaking change (fix or feature that would cause existing functionality to change)
New feature (non-breaking change which adds functionality)
Bug fix (non-breaking change which fixes an issue)
Enhancement (improves an existing feature and functionality)
Cleanup (Code refactoring and cleanup, that may add test cases)

listVolume response will now have:

      "diskioread": 631,
      "diskiowrite": 130,
      "diskkbsread": 15084,
      "diskkbswrite": 135,

listVolumeMetrics response will have:

      "diskiopstotal": 761,
      "diskioread": 631,
      "diskiowrite": 130,
      "diskkbsread": 15084,
      "diskkbswrite": 135,

yadvr · 2019-04-05T07:43:35Z

    }

    protected Answer execute(GetVmDiskStatsCommand cmd) {
+        // TODO: implement for Vmware


Use/extend perfcounter, and see https://www.vmware.com/support/developer/converter-sdk/conv61_apireference/virtual_disk_counters.html for disk read/write and iops

anuragaw · 2019-04-10T06:05:15Z

@blueorangutan package

blueorangutan · 2019-04-10T06:06:03Z

@anuragaw a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

blueorangutan · 2019-04-10T06:26:37Z

Packaging result: ✔centos6 ✔centos7 ✔debian. JID-2690

anuragaw · 2019-04-11T13:56:00Z

+                final VirtualMachineMO vmMo = dcMo.findVm(vmName);
+                final List<VmDiskStatsEntry> diskStats = new ArrayList<>();
+                for (VirtualDisk disk : vmMo.getAllDiskDevice()) {
+                    // TODO Get UUID, PATH of VirtualDisk


WIP - need to figure this out before testing end to end. CC/ @rhtyd

…ics API This re-uses an existing volume stats dao/table to display the volume specific disk read/write bytes and iops statistics via the listVolumes and listVolumeMetrics API, as well as display granular metrics in the UI. TODO: implement support for VMware and possibly for XenServer? Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>

yadvr · 2019-04-15T08:59:40Z

@blueorangutan package

blueorangutan · 2019-04-15T09:00:26Z

@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

blueorangutan · 2019-04-15T09:21:41Z

Packaging result: ✔centos6 ✔centos7 ✔debian. JID-2699

Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>

borisstoyanov · 2019-04-17T09:47:40Z

@blueorangutan package

blueorangutan · 2019-04-17T09:48:35Z

@borisstoyanov a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

blueorangutan · 2019-04-17T10:09:29Z

Packaging result: ✔centos6 ✔centos7 ✔debian. JID-2705

borisstoyanov · 2019-04-18T11:21:41Z

@blueorangutan test

blueorangutan · 2019-04-18T11:22:40Z

@borisstoyanov a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

blueorangutan · 2019-04-18T18:43:46Z

Trillian test result (tid-3502)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 24794 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr3259-t3502-kvm-centos7.zip
Smoke tests completed. 70 look OK, 0 have error(s)
Only failed tests results shown below:

Test	Result	Time (s)	Test File

borisstoyanov

LGTM

yadvr · 2019-06-07T07:37:31Z

@blueorangutan test centos7 vmware-65u2

blueorangutan · 2019-06-07T07:38:01Z

@rhtyd a Trillian-Jenkins test job (centos7 mgmt + vmware-65u2) has been kicked to run smoke tests

borisstoyanov

LGTM test results attached
test_results.xlsx

yadvr · 2019-06-18T08:33:42Z

@blueorangutan test centos7 vmware65u2

blueorangutan · 2019-06-18T08:34:48Z

@rhtyd unsupported parameters provided. Supported mgmt server os are: centos6, centos7, ubuntu. Supported hypervisors are: kvm-centos6, kvm-centos7, kvm-ubuntu, xenserver-71, xenserver-65sp1, xenserver-62sp1, vmware-65u2, vmware-60u2, vmware-55u3, vmware-51u1, vmware-50u1

yadvr · 2019-06-18T11:17:25Z

@blueorangutan test centos7 vmware-65u2

blueorangutan · 2019-06-18T11:17:49Z

@rhtyd a Trillian-Jenkins test job (centos7 mgmt + vmware-65u2) has been kicked to run smoke tests

anuragaw

LGTM from code and local testing

blueorangutan · 2019-06-18T20:37:58Z

Trillian test result (tid-3703)
Environment: vmware-65u2 (x2), Advanced Networking with Mgmt server 7
Total time taken: 32250 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr3259-t3703-vmware-65u2.zip
Intermittent failure detected: /marvin/tests/smoke/test_snapshots.py
Intermittent failure detected: /marvin/tests/smoke/test_usage.py
Smoke tests completed. 69 look OK, 2 have error(s)
Only failed tests results shown below:

Test	Result	Time (s)	Test File
test_02_list_snapshots_with_removed_data_store	`Error`	1.15	test_snapshots.py
test_01_volume_usage	`Error`	9.35	test_usage.py

Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>

yadvr · 2019-06-20T09:32:52Z

Fixed conflicts
@blueorangutan package

blueorangutan · 2019-06-20T09:32:56Z

@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

blueorangutan · 2019-06-20T10:34:34Z

Packaging result: ✖centos6 ✔centos7 ✔debian. JID-2908

yadvr · 2019-06-20T12:14:47Z

@blueorangutan package

blueorangutan · 2019-06-20T12:14:57Z

@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

blueorangutan · 2019-06-20T12:34:37Z

Packaging result: ✔centos6 ✔centos7 ✔debian. JID-2913

yadvr · 2019-06-24T09:36:40Z

@blueorangutan package

blueorangutan · 2019-06-24T09:37:03Z

@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

yadvr · 2019-06-25T08:29:09Z

@blueorangutan package

blueorangutan · 2019-06-25T08:30:10Z

@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

blueorangutan · 2019-06-25T09:12:06Z

Packaging result: ✔centos6 ✔centos7 ✔debian. JID-17

yadvr · 2019-06-25T09:29:36Z

@blueorangutan test centos7 vmware-65u2

blueorangutan · 2019-06-25T09:30:09Z

@rhtyd a Trillian-Jenkins test job (centos7 mgmt + vmware-65u2) has been kicked to run smoke tests

blueorangutan · 2019-06-25T19:04:30Z

Trillian test result (tid-15)
Environment: vmware-65u2 (x2), Advanced Networking with Mgmt server 7
Total time taken: 33050 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr3259-t15-vmware-65u2.zip
Intermittent failure detected: /marvin/tests/smoke/test_snapshots.py
Intermittent failure detected: /marvin/tests/smoke/test_usage.py
Smoke tests completed. 69 look OK, 2 have error(s)
Only failed tests results shown below:

Test	Result	Time (s)	Test File
test_02_list_snapshots_with_removed_data_store	`Error`	1.13	test_snapshots.py
test_01_volume_usage	`Error`	8.27	test_usage.py

yadvr · 2019-06-25T19:06:19Z

@blueorangutan test centos7 vmware-65u2

blueorangutan · 2019-06-25T19:07:10Z

@rhtyd a Trillian-Jenkins test job (centos7 mgmt + vmware-65u2) has been kicked to run smoke tests

blueorangutan · 2019-06-26T04:30:33Z

Trillian test result (tid-27)
Environment: vmware-65u2 (x2), Advanced Networking with Mgmt server 7
Total time taken: 32402 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr3259-t27-vmware-65u2.zip
Intermittent failure detected: /marvin/tests/smoke/test_deploy_vm_root_resize.py
Intermittent failure detected: /marvin/tests/smoke/test_snapshots.py
Intermittent failure detected: /marvin/tests/smoke/test_usage.py
Smoke tests completed. 69 look OK, 2 have error(s)
Only failed tests results shown below:

Test	Result	Time (s)	Test File
test_02_list_snapshots_with_removed_data_store	`Error`	1.13	test_snapshots.py
test_01_volume_usage	`Error`	8.29	test_usage.py

yadvr added component:vmware component:primary-storage labels Apr 4, 2019

yadvr added this to the 4.13.0.0 milestone Apr 4, 2019

yadvr commented Apr 5, 2019

View reviewed changes

anuragaw reviewed Apr 11, 2019

View reviewed changes

yadvr and others added 3 commits April 15, 2019 14:28

Add support to VMWare for collecting VM Disk Statistics

c510256

Use vDiskId for UUID

0b72f55

yadvr force-pushed the granular-disk-metrics branch from c3d7541 to 0b72f55 Compare April 15, 2019 08:59

yadvr added 4 commits April 15, 2019 18:11

wip perf count/stats code

1db44c2

Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>

implement perf counter

05c1685

Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>

fix perf stats gathering wrt both disks and VM

68c94f5

Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>

use only series for the vm instance name as counter instance name

df25146

Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>

yadvr force-pushed the granular-disk-metrics branch from 2bbfcbe to df25146 Compare April 16, 2019 11:57

yadvr added 3 commits April 17, 2019 13:10

Update CitrixGetVmDiskStatsCommandWrapper.java

07c5d1b

Update StatsCollector.java

b205e5f

Update UserVmManagerImpl.java

80dcb4b

borisstoyanov approved these changes Apr 22, 2019

View reviewed changes

borisstoyanov approved these changes Jun 7, 2019

View reviewed changes

apache deleted a comment from blueorangutan Jun 18, 2019

anuragaw approved these changes Jun 18, 2019

View reviewed changes

Merge remote-tracking branch 'origin/master' into granular-disk-metrics

cf3dea4

Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>

yadvr changed the title ~~[WIP DO NOT MERGE] server: export granular volume bytes and iops metrics~~ server: export granular volume bytes and iops metrics Jun 27, 2019

yadvr merged commit 14bff7b into apache:master Jun 27, 2019

Uh oh!

Conversation

yadvr commented Apr 4, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Types of changes

Uh oh!

yadvr Apr 5, 2019

Choose a reason for hiding this comment

Uh oh!

anuragaw commented Apr 10, 2019

Uh oh!

blueorangutan commented Apr 10, 2019

Uh oh!

blueorangutan commented Apr 10, 2019

Uh oh!

anuragaw Apr 11, 2019

Choose a reason for hiding this comment

Uh oh!

yadvr commented Apr 15, 2019

Uh oh!

blueorangutan commented Apr 15, 2019

Uh oh!

blueorangutan commented Apr 15, 2019

Uh oh!

borisstoyanov commented Apr 17, 2019

Uh oh!

blueorangutan commented Apr 17, 2019

Uh oh!

blueorangutan commented Apr 17, 2019

Uh oh!

borisstoyanov commented Apr 18, 2019

Uh oh!

blueorangutan commented Apr 18, 2019

Uh oh!

blueorangutan commented Apr 18, 2019

Uh oh!

borisstoyanov left a comment

Choose a reason for hiding this comment

Uh oh!

yadvr commented Jun 7, 2019

Uh oh!

blueorangutan commented Jun 7, 2019

Uh oh!

borisstoyanov left a comment

Choose a reason for hiding this comment

Uh oh!

yadvr commented Jun 18, 2019

Uh oh!

blueorangutan commented Jun 18, 2019

Uh oh!

yadvr commented Jun 18, 2019

Uh oh!

blueorangutan commented Jun 18, 2019

Uh oh!

anuragaw left a comment

Choose a reason for hiding this comment

Uh oh!

blueorangutan commented Jun 18, 2019

Uh oh!

yadvr commented Jun 20, 2019

Uh oh!

blueorangutan commented Jun 20, 2019

Uh oh!

blueorangutan commented Jun 20, 2019

Uh oh!

yadvr commented Jun 20, 2019

Uh oh!

blueorangutan commented Jun 20, 2019

Uh oh!

blueorangutan commented Jun 20, 2019

Uh oh!

yadvr commented Jun 24, 2019

Uh oh!

blueorangutan commented Jun 24, 2019

Uh oh!

yadvr commented Jun 25, 2019

Uh oh!

blueorangutan commented Jun 25, 2019

Uh oh!

blueorangutan commented Jun 25, 2019

yadvr commented Apr 4, 2019 •

edited

Loading