Skip to content

[CLOUDSTACK-10406] fix bugs that may cause program crash, change mkdir to mkdirs#3249

Merged
DaanHoogland merged 1 commit into
apache:4.12from
bd2019us:CLOUDSTACK-10406-4.12
Apr 5, 2019
Merged

[CLOUDSTACK-10406] fix bugs that may cause program crash, change mkdir to mkdirs#3249
DaanHoogland merged 1 commit into
apache:4.12from
bd2019us:CLOUDSTACK-10406-4.12

Conversation

@bd2019us

@bd2019us bd2019us commented Mar 31, 2019

Copy link
Copy Markdown
Contributor

Description

Fixes: #CLOUDSTACK-10406

Types of changes

  • [x ] Bug fix (non-breaking change which fixes an issue)

@yadvr yadvr added this to the 4.13.0.0 milestone Apr 1, 2019
@yadvr yadvr added the type:bug label Apr 1, 2019
@bd2019us

bd2019us commented Apr 2, 2019

Copy link
Copy Markdown
Contributor Author

retest please, the code change should not cause any test case failing.

@DaanHoogland

Copy link
Copy Markdown
Contributor

@bd2019us the test are not reliable. code looks good, we'll run some integration tests in surplus.
Please use github issues in the future, we stopped using jira (which doesn't matter in this case as you came up with your own fix ;)
@blueorangutan package

@blueorangutan

Copy link
Copy Markdown

@DaanHoogland a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

@blueorangutan

Copy link
Copy Markdown

Packaging result: ✔centos6 ✔centos7 ✔debian. JID-2671

@DaanHoogland

Copy link
Copy Markdown
Contributor

@blueorangutan test

@blueorangutan

Copy link
Copy Markdown

@DaanHoogland a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

@bd2019us

bd2019us commented Apr 3, 2019

Copy link
Copy Markdown
Contributor Author

@DaanHoogland Thanks for your information.

@blueorangutan

Copy link
Copy Markdown

Trillian test result (tid-3464)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 38323 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr3249-t3464-kvm-centos7.zip
Intermittent failure detected: /marvin/tests/smoke/test_deploy_virtio_scsi_vm.py
Intermittent failure detected: /marvin/tests/smoke/test_diagnostics.py
Intermittent failure detected: /marvin/tests/smoke/test_internal_lb.py
Intermittent failure detected: /marvin/tests/smoke/test_privategw_acl.py
Intermittent failure detected: /marvin/tests/smoke/test_ssvm.py
Intermittent failure detected: /marvin/tests/smoke/test_hostha_kvm.py
Smoke tests completed. 67 look OK, 3 have error(s)
Only failed tests results shown below:

Test Result Time (s) Test File
test_04_verify_guest_lspci Error 810.69 test_deploy_virtio_scsi_vm.py
test_06_verify_guest_lspci_again Error 810.69 test_deploy_virtio_scsi_vm.py
test_01_ping_in_vr_success Error 60.78 test_diagnostics.py
test_02_ping_in_vr_failure Error 60.65 test_diagnostics.py
test_07_arping_in_vr Failure 5.21 test_diagnostics.py
test_08_arping_in_ssvm Failure 5.22 test_diagnostics.py
test_09_arping_in_cpvm Failure 5.21 test_diagnostics.py
test_hostha_enable_ha_when_host_disabled Error 4.66 test_hostha_kvm.py
test_hostha_enable_ha_when_host_in_maintenance Error 301.87 test_hostha_kvm.py

@yadvr

yadvr commented Apr 5, 2019

Copy link
Copy Markdown
Member

Failures not related to the change.

@DaanHoogland
DaanHoogland merged commit 09045bd into apache:4.12 Apr 5, 2019
DaanHoogland added a commit that referenced this pull request Apr 5, 2019
* 4.12:
  fix bugs that may cause program crash, change mkdir to mkdirs (#3249)
pbankonier pushed a commit to pbankonier/cloudstack that referenced this pull request Apr 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants