api: add command to list management servers

[marcaurele]

Description

New API command to list the management servers, following the discussion on the mailing list. It adds back (I think it was removed at some point) the uuid column in the mshost table. It adds another change: the management server name is picked up from the canonical name to try to get the full name of the server for scripting purpose (for example for a SSH remote connection).

Types of changes

• Breaking change (fix or feature that would cause existing functionality to change)
• New feature (non-breaking change which adds functionality)
• Bug fix (non-breaking change which fixes an issue)
• Enhancement (improves an existing feature and functionality)
• Cleanup (Code refactoring and cleanup, that may add test cases)

How Has This Been Tested?

The web interface has been tested locally along with the API call to list the management servers.

Checklist:

• I have read the CONTRIBUTING document.
• My code follows the code style of this project.
• My change requires a change to the documentation.
• I have updated the documentation accordingly.
  Testing
• I have added tests to cover my changes.
• All relevant new and existing integration tests have passed.
• A full integration testsuite with all test that can run on my environment has passed.

@blueorangutan package

[blueorangutan]

@marcaurele a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

[DaanHoogland]

looks good but misses tests. this will be code at the basis of shutdown procedure. tests will be very much apreciated.

[blueorangutan]

Packaging result: ✔centos6 ✔centos7 ✖debian. JID-1940

[marcaurele]

@DaanHoogland what kind of tests do you expect on a pure list operation ? I thought it's pretty straight forward and would not need any test but I'm open to add some, just not sure what to test there.

[DaanHoogland]

@marcaurele I don't expect test on the list operation. it is to trivial. I am thinking about the underlying constructs, the change in the peer object, mainly. If you think those changes are to trivial as well, soit. 33 files have changed but admitted most of them only slightly.
We are going to build onb this so we might also do it in future work ;)

[DaanHoogland]

closing to trigger CI anew

[DaanHoogland]

open sesame (and jenkins/travis)

[blueorangutan]

@marcaurele a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

[blueorangutan]

Packaging result: ✔centos6 ✔centos7 ✔debian. JID-1947

[yadvr]

@marcaurele nice, can you also consider adding UI changes such as a tab on left nav-bar or a section/tab on the infra page?

[marcaurele]

@rhtyd Ok

[marcaurele]

@rhtyd is there a source for those system images in the WUI? I would need a new one for the management server but dunno where to look for one alike.

[yadvr]

@marcaurele sorry did not get the question, if you're looking for link/url where systemvmtemplates are hosted you can use the http://download.cloudstack.org/ server. Or, if you mean by having an icon for the tab see if you can find one from sprites.png or add a new one in any free space in sprites.png

[marcaurele]

@rhtyd it was about the sprites, but I found the one I was looking for infrastructure-icons.png which does not have anything for a management server... Due you know what is the source of those images? I might simply use the same as the systemVM for the management.

[DaanHoogland]

@marcaurele this got outdated, are you still on it?

[marcaurele]

Moving forward, infra page lists the number of management servers:

[marcaurele]

Getting better, detail view is ready too

[marcaurele]

› cs listManagementServers --region=dev:admin    
{
  "count": 3,
  "managementserver": [
    {
      "id": "5a45d7ec-4504-4c7e-a816-76e56e030a65",
      "name": "liskam",
      "state": "Down",
      "version": "4.12.0.0-SNAPSHOT"
    },
    {
      "id": "2510dd9d-51e0-4523-9198-28835a7b2100",
      "name": "liskam",
      "state": "Down",
      "version": "4.12.0.0-SNAPSHOT"
    },
    {
      "id": "06a3eb78-cd20-42d5-ae17-9084559134d0",
      "name": "liskam",
      "state": "Up",
      "version": "4.12.0.0-SNAPSHOT"
    }
  ]
}

[marcaurele]

The PR is ready now. Conflicts are fixed, WUI is updated with a new block for management servers with a simple detail view. cc @rhtyd @DaanHoogland @rafaelweingartner @bwsw

[yadvr]

Looks great @marcaurele I'm busy this week with some outstanding issues wrt 4.11.2 release. I'll review this after that. Thanks.

[rafaelweingartner]

@blueorangutan package

[blueorangutan]

@rafaelweingartner a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

[blueorangutan]

Packaging result: ✔centos6 ✔centos7 ✖debian. JID-2361

[GabrielBrascher]

@marcaurele interesting feature 👍
It would be great to have this on 4.12.0. Could you please resolve the conflicts?

[DaanHoogland]

@GabrielBrascher as @marcaurele indicated he's leaving the community I'll fork his branch and resubmit his code to address any issue we might still have with it.

[GabrielBrascher]

@DaanHoogland sounds like a plan, thanks for pointing it out. This PR is on the list of PRs that are interesting to be merged but still need some time invested; it is almost ready, just need fixing conflicts so I hope to have it on 4.12.

[DaanHoogland]

closing this in favour of #3150. I'll get to addressing the comments I find here in that PR

[blueorangutan]

@marcaurele a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

[blueorangutan]

Packaging result: ✖centos6 ✖centos7 ✖debian. JID-2569

[marcaurele]

Sorry guys, but I don't have anymore much time to continue rebasing my code as it's not going through quick enough to avoid new conflicts. thanks @DaanHoogland to take over.

[DaanHoogland]

no worries @marcaurele , I know you changed focus and it is all but done. thanks for much good cooperative work over the years 👍