Skip to content

Improve Spanish translation#2571

Closed
jorgesumle wants to merge 2 commits into
apache:masterfrom
jorgesumle:spanish-translation
Closed

Improve Spanish translation#2571
jorgesumle wants to merge 2 commits into
apache:masterfrom
jorgesumle:spanish-translation

Conversation

@jorgesumle

Copy link
Copy Markdown
Contributor

Description

Improve Spanish translation:

  • Pone coma después de «por favor». El complemento oracional «por favor» debe ir seguido de una coma.
  • Añade signos de interrogación de apertura donde he encontrado sin cerrar.
  • Correcciones menores.
  • «Está seguro que» es un queísmo. Lo he corregido.
  • Pone tilde a «esta» cuando se usa como verbo.
  • Pone tilde a «mio».

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)

GitHub Issue/PRs

Fixes #2569

But I didn't review it throughly enough, so maybe there are more small little errors.

Screenshots (if appropriate):

How Has This Been Tested?

Checklist:

  • I have read the CONTRIBUTING document.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
    Testing
  • I have added tests to cover my changes.
  • All relevant new and existing integration tests have passed.
  • A full integration testsuite with all test that can run on my environment has passed.

- Pone coma después de «por favor». El complemento oracional «por favor» debe ir seguido de una coma.
- Añade signos de interrogación de apertura donde he encontrado sin cerrar.
- Correcciones menores.
- «Está seguro que» es un queísmo. Lo he corregido.
- Pone tilde a «esta» cuando se usa como verbo.
- Pone tilde a «mio».
@rafaelweingartner

Copy link
Copy Markdown
Member

We will need Spanish speakers to help us review this one :)

@DaanHoogland

Copy link
Copy Markdown
Contributor

@milamberspace can you please advise if this is the proper way to go?

Comment thread ui/l10n/es.js Outdated
"force.remove.host.warning": "Advertencia: Elegir esta opción provocará que CloudStack detenga a la fuerza todas las máquinas virtuales antes de eliminar este host del clúster.",
"force.stop": "Forzar Parar",
"force.stop.instance.warning": "Advertencia: Forzar la dertención de esta instancia deberí­a ser su última opción. Puede conducir a la pérdida de datos, así­ como un comportamiento incoherente del estado de la máquina virtual.",
"force.stop.instance.warning": "Advertencia: Forzar la dertención de esta instancia debería­a ser su última opción. Puede conducir a la pérdida de datos, así­ como un comportamiento incoherente del estado de la máquina virtual.",

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Extra 'a' on 'debería'

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a weird GitHub bug. Download the file with wget and you'll see that the extra 'a' doesn't exist. I didn't report it to GitHub because I don't collaborate with proprietary software.

@rafaelweingartner rafaelweingartner Apr 13, 2018

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is because you are writing debería-a. For some reason that - is being removed in the HTML. It might be some escaping problem in Github.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a soft hyphen. I couldn't see it with Vim.

Comment thread ui/l10n/es.js
"message.step.4.desc": "Por favor, seleccione la red primaria a la que estará conectada su instancia virtual",
"message.storage.traffic": "Tráfico entre los recursos internos de CloudStack, incluyendo cualquier componente que se comunique con el servidor de gestión, tales como anfitriones y las Mvs de sistema de CloudStack. Por favor, configure el tráfico del almacenamiento aquí.",
"message.suspend.project": "¿Está seguro que desea suspender este proyecto?",
"message.suspend.project": "¿Está seguro de que desea suspender este proyecto?",

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not a linguist but I think 'de' is not needed in this case, even though on speaking both ways may be accepted :)

@jorgesumle jorgesumle Apr 13, 2018

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mira el artículo de Wikipedia sobre queísmo. Precisamente hay un ejemplo con «seguro de». En foros de idiomas y en la RAE vas a encontrar lo mismo.

EDIT to add English translation: See the Wikipedia article about queísmo. There is an example with "seguro que". In language forums and the RAE [a Spanish language academia] you'll find the same.

@nvazquez nvazquez left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As a native spanish speaker, it LGTM.
@jorgesumle I left some comments but overall looks good. Can you please translate the PR description in Spanish to English?

@jorgesumle

Copy link
Copy Markdown
Contributor Author

you please translate the PR description in Spanish to English?

I would have to link to every grammar rule I quoted and there are no equivalence for some in English (like queísmo, complemento oracional, diacritic), and only Spanish-speakers should review it anyway, so I don't think it's necessary.

@milamberspace

Copy link
Copy Markdown
Contributor

Please note : We use Transifex for the translation of Web UI. You need bring your changes on Transifex otherwise they will be erased on next update (when we download the messages files from transifex to the repo)

https://www.transifex.com/ke4qqq/CloudStack_UI/410_messagesjson/

@jorgesumle

Copy link
Copy Markdown
Contributor Author

I opened a pull request because I was told to do that (see #2569). I won't use Transifex as it requires proprietary JavaScript code to be executed. I hope someone can volunteer to upload the updates for me or (better yet) use a free replacement to Transifex.

@jorgesumle jorgesumle closed this Apr 14, 2018
@rafaelweingartner

Copy link
Copy Markdown
Member

@milamberspace how does transifex work? I mean, if I create a new key, does it pick that key automatically?
Do we have a documentation that talks about the process of generating new message keys?

@milamberspace

Copy link
Copy Markdown
Contributor

@rafaelweingartner The process is describe here ./tools/transifex/README-transifex.txt

and on (to update the resources)
https://cwiki.apache.org/confluence/display/CLOUDSTACK/Update+L10N+files+from+Transifex+to+git+repo

@rafaelweingartner

Copy link
Copy Markdown
Member

@milamberspace thanks!
The page in our wiki is outdated, but the README file is updated :)
I will send the new keys to transifex, and then I will also update the translations suggested here as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Errors in Spanish translation

5 participants