Fix the name of the column used to hold IPv4 range in 'vlan' table. by rafaelweingartner · Pull Request #2492 · apache/cloudstack

rafaelweingartner · 2018-03-15T18:48:28Z

The title says everything...

yadvr · 2018-03-16T02:36:43Z

Can you check the build failures @rafaelweingartner?

rafaelweingartner · 2018-03-16T09:20:51Z

The problems are due to that issue with the agent-lb component. As soon as we merge that, we fix all of these issues.

DaanHoogland

probably a very old bug, thanks for fixing @rafaelweingartner

DaanHoogland · 2018-03-16T11:13:43Z

@rafaelweingartner package

DaanHoogland · 2018-03-16T11:35:44Z

@rafaelweingartner you are free to help if you wish but
@blueorangutan package

rafaelweingartner · 2018-03-16T11:36:35Z

Sorry, I did not understand.
Do you need help for something?

blueorangutan · 2018-03-16T11:36:35Z

@DaanHoogland a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

DaanHoogland · 2018-03-16T11:37:31Z

i commented @rafaelweingartner package

blueorangutan · 2018-03-16T12:11:22Z

Packaging result: ✔centos6 ✔centos7 ✔debian. JID-1786

DaanHoogland · 2018-03-18T20:03:52Z

@blueorangutan test

blueorangutan · 2018-03-18T20:04:45Z

@DaanHoogland a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

blueorangutan · 2018-03-19T05:35:33Z

Trillian test result (tid-2389)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 32673 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr2492-t2389-kvm-centos7.zip
Intermitten failure detected: /marvin/tests/smoke/test_certauthority_root.py
Intermitten failure detected: /marvin/tests/smoke/test_deploy_virtio_scsi_vm.py
Intermitten failure detected: /marvin/tests/smoke/test_privategw_acl.py
Intermitten failure detected: /marvin/tests/smoke/test_public_ip_range.py
Intermitten failure detected: /marvin/tests/smoke/test_templates.py
Intermitten failure detected: /marvin/tests/smoke/test_usage.py
Intermitten failure detected: /marvin/tests/smoke/test_volumes.py
Intermitten failure detected: /marvin/tests/smoke/test_vpc_redundant.py
Intermitten failure detected: /marvin/tests/smoke/test_vpc_vpn.py
Intermitten failure detected: /marvin/tests/smoke/test_hostha_kvm.py
Smoke tests completed. 62 look OK, 5 have error(s)
Only failed tests results shown below:

Test	Result	Time (s)	Test File
test_04_extract_template	`Failure`	128.28	test_templates.py
ContextSuite context=TestISOUsage>:setup	`Error`	0.00	test_usage.py
test_06_download_detached_volume	`Failure`	138.67	test_volumes.py
test_04_rvpc_network_garbage_collector_nics	`Failure`	497.17	test_vpc_redundant.py
test_hostha_enable_ha_when_host_in_maintenance	`Error`	1.53	test_hostha_kvm.py

nitin-maharana · 2018-03-19T09:59:36Z

Thanks for the fix. Code LGTM.

rafaelweingartner · 2018-03-19T10:00:51Z

@nitin-maharana can you use the Github review/approval method? It facilitate for us when checking if a PR is ready to be managed.

Thanks for the reviews.

DaanHoogland · 2018-03-19T11:24:58Z

@nitin-maharana it's fine for now but @rafaelweingartner is right that it is easier to see if a PR is ready for merge if you use the review button.... reviewing the failed tests to see if these are structural.

DaanHoogland · 2018-03-19T11:42:57Z

all failures seem unrelated to this code, rerunning to get another hint
@blueorangutan test

blueorangutan · 2018-03-19T11:43:48Z

@DaanHoogland a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

blueorangutan · 2018-03-19T18:49:43Z

Trillian test result (tid-2392)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 23791 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr2492-t2392-kvm-centos7.zip
Intermitten failure detected: /marvin/tests/smoke/test_certauthority_root.py
Intermitten failure detected: /marvin/tests/smoke/test_ssvm.py
Intermitten failure detected: /marvin/tests/smoke/test_vpc_redundant.py
Intermitten failure detected: /marvin/tests/smoke/test_host_maintenance.py
Intermitten failure detected: /marvin/tests/smoke/test_hostha_kvm.py
Smoke tests completed. 64 look OK, 3 have error(s)
Only failed tests results shown below:

Test	Result	Time (s)	Test File
test_03_ssvm_internals	`Failure`	3.64	test_ssvm.py
test_04_rvpc_network_garbage_collector_nics	`Failure`	257.95	test_vpc_redundant.py
test_05_rvpc_multi_tiers	`Failure`	324.03	test_vpc_redundant.py
test_05_rvpc_multi_tiers	`Error`	349.66	test_vpc_redundant.py
test_hostha_enable_ha_when_host_in_maintenance	`Error`	0.93	test_hostha_kvm.py

borisstoyanov

@rafaelweingartner have you seen these 2 PR and do you think these changes can be problematic, probably not since this will be in 4.12...
#2449
#2490

rafaelweingartner · 2018-03-20T10:35:28Z

Yes I have. Why do you think it can be problematic?
The problem is not with this PR per se, but the same old discussion, the way we are using to manage data model scrips.

The upgrade path from 4.11 to 4.12 was created before the 4.11 to 4.11.1. This will create for sure a problem, which I am not sure how to handle yet.

yadvr · 2018-03-21T16:16:10Z

@rafaelweingartner it will depend on which version gets out of the door first. Usually, you would do something like: 4.11.0.0-> 4.11.1.0 -> 4.12.0.0 assuming 4.11.1.0 gets out of the door before 4.12.0.0, in which case the 4.11.0.0->4.12.0.0 file names could be renamed to reflect 4.11.1.0->4.12.0.0. There are no changes required from your end wrt this PR.

rafaelweingartner · 2018-03-22T13:48:37Z

I agree with @rhtyd.
@borisstoyanov are those errors intermittent ones? I think I have seen similar ones in other PRs.

borisstoyanov · 2018-03-22T19:35:21Z

yes @rafaelweingartner we've seen them before.

rafaelweingartner · 2018-03-22T19:40:26Z

Can I consider then that everything is ok, and merge this PR?

yadvr · 2018-03-23T06:19:43Z

I see some new failures, let me re-kick tests one more time.
@blueorangutan test centos7 vmware-65

blueorangutan · 2018-03-23T06:20:04Z

@rhtyd a Trillian-Jenkins test job (centos7 mgmt + vmware-65) has been kicked to run smoke tests

blueorangutan · 2018-03-23T17:09:36Z

Trillian test result (tid-2405)
Environment: vmware-65 (x2), Advanced Networking with Mgmt server 7
Total time taken: 37606 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr2492-t2405-vmware-65.zip
Intermitten failure detected: /marvin/tests/smoke/test_certauthority_root.py
Intermitten failure detected: /marvin/tests/smoke/test_deploy_vgpu_enabled_vm.py
Intermitten failure detected: /marvin/tests/smoke/test_router_dhcphosts.py
Intermitten failure detected: /marvin/tests/smoke/test_service_offerings.py
Intermitten failure detected: /marvin/tests/smoke/test_vm_life_cycle.py
Intermitten failure detected: /marvin/tests/smoke/test_vpc_redundant.py
Smoke tests completed. 64 look OK, 3 have error(s)
Only failed tests results shown below:

Test	Result	Time (s)	Test File
ContextSuite context=TestCpuCapServiceOfferings>:teardown	`Error`	0.00	test_service_offerings.py
test_08_migrate_vm	`Error`	45.26	test_vm_life_cycle.py
test_04_rvpc_network_garbage_collector_nics	`Failure`	590.79	test_vpc_redundant.py

rafaelweingartner · 2018-03-23T17:11:04Z

Errors changed again... I believe this is a good sign somehow...

rafaelweingartner · 2018-03-28T16:02:20Z

@borisstoyanov are these errors intermittent ones?

borisstoyanov · 2018-03-28T17:27:26Z

These errors aren't reported frequently.. but I don't think they're related... don't see any reason to..

rafaelweingartner · 2018-03-29T13:02:28Z

I have seen this test_04_rvpc_network_garbage_collector_nics test failing in other PRs as well. @borisstoyanov would you like to run some more tests, or you are ok with the results so far?

borisstoyanov

LGTM

Correção do componente _slider_ das configurações globais do tipo `Range` Closes apache#2492 See merge request scclouds/scclouds!1065

rafaelweingartner added the type:cleanup label Mar 15, 2018

rafaelweingartner added this to the 4.12.0.0 milestone Mar 15, 2018

rafaelweingartner self-assigned this Mar 15, 2018

rafaelweingartner force-pushed the fixIpv4RangeFieldInVlanTable branch from 5a50ef4 to 296da7a Compare March 15, 2018 22:18

Fix the name of the column used to hold IPv4 range in 'vlan' table.

6d89e7a

rafaelweingartner force-pushed the fixIpv4RangeFieldInVlanTable branch from 296da7a to 6d89e7a Compare March 16, 2018 09:32

DaanHoogland self-requested a review March 16, 2018 11:12

DaanHoogland approved these changes Mar 16, 2018

View reviewed changes

borisstoyanov reviewed Mar 20, 2018

View reviewed changes

borisstoyanov approved these changes Mar 29, 2018

View reviewed changes

rafaelweingartner merged commit 3868886 into apache:master Mar 29, 2018

Uh oh!

Conversation

rafaelweingartner commented Mar 15, 2018

Uh oh!

yadvr commented Mar 16, 2018

Uh oh!

rafaelweingartner commented Mar 16, 2018

Uh oh!

DaanHoogland left a comment

Choose a reason for hiding this comment

Uh oh!

DaanHoogland commented Mar 16, 2018

Uh oh!

DaanHoogland commented Mar 16, 2018

Uh oh!

rafaelweingartner commented Mar 16, 2018

Uh oh!

blueorangutan commented Mar 16, 2018

Uh oh!

DaanHoogland commented Mar 16, 2018

Uh oh!

blueorangutan commented Mar 16, 2018

Uh oh!

DaanHoogland commented Mar 18, 2018

Uh oh!

blueorangutan commented Mar 18, 2018

Uh oh!

blueorangutan commented Mar 19, 2018

Uh oh!

nitin-maharana commented Mar 19, 2018

Uh oh!

rafaelweingartner commented Mar 19, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

DaanHoogland commented Mar 19, 2018

Uh oh!

DaanHoogland commented Mar 19, 2018

Uh oh!

blueorangutan commented Mar 19, 2018

Uh oh!

blueorangutan commented Mar 19, 2018

Uh oh!

borisstoyanov left a comment

Choose a reason for hiding this comment

Uh oh!

rafaelweingartner commented Mar 20, 2018

Uh oh!

yadvr commented Mar 21, 2018

Uh oh!

rafaelweingartner commented Mar 22, 2018

Uh oh!

borisstoyanov commented Mar 22, 2018

Uh oh!

rafaelweingartner commented Mar 22, 2018

Uh oh!

yadvr commented Mar 23, 2018

Uh oh!

blueorangutan commented Mar 23, 2018

Uh oh!

blueorangutan commented Mar 23, 2018

Uh oh!

rafaelweingartner commented Mar 23, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rafaelweingartner commented Mar 28, 2018

Uh oh!

borisstoyanov commented Mar 28, 2018

Uh oh!

rafaelweingartner commented Mar 29, 2018

Uh oh!

borisstoyanov left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

rafaelweingartner commented Mar 19, 2018 •

edited

Loading

rafaelweingartner commented Mar 23, 2018 •

edited

Loading