Skip to content

Fix CODEOWNERS remove users that don't have write access - #14714

Open
jbampton wants to merge 1 commit into
apache:mainfrom
jbampton:fix-codeowners
Open

jbampton wants to merge 1 commit into
apache:mainfrom
jbampton:fix-codeowners

Conversation

@jbampton

Copy link
Copy Markdown
Member

Description

This PR fixes the CODEOWNERS file. The people you choose as code owners must have write permissions for the repository.

At the next link there is a warning message saying the CODEOWNERS file is not valid:

https://github.com/apache/cloudstack/blob/main/.github/CODEOWNERS

https://docs.github.com/en/repositories/managing-your-repositorys-settings-and-features/customizing-your-repository/about-code-owners

Screenshot 2026-11-17 at 5 44 59 am Screenshot 2026-11-17 at 5 39 52 am

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • Build/CI
  • Test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

@jbampton
jbampton requested review from nvazquez and a balanced review from Copilot November 16, 2026 19:49
@codecov

codecov Bot commented Nov 16, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 20.78%. Comparing base (278bde2) to head (5de9221).

Additional details and impacted files
@@            Coverage Diff            @@
##               main   #14714   +/-   ##
=========================================
  Coverage     20.78%   20.78%           
- Complexity    20857    20858    +1     
=========================================
  Files          6053     6053           
  Lines        548230   548230           
  Branches      73237    73237           
=========================================
  Hits         113928   113928           
  Misses       420955   420955           
  Partials      13347    13347           
Flag Coverage Δ
uitests 3.86% <ø> (ø)
unittests 22.21% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

No active review issues block the CODEOWNERS cleanup.

No open issues 🎉

What changed in this PR

This PR updates CloudStack’s code-owner configuration to address GitHub validation warnings about owners lacking repository write access.

Changes:

  • Removes the ONTAP storage plugin’s ownership entry and its six listed owners.
  • Leaves all other ownership entries unchanged.
File Description
.github/​CODEOWNERS Removes the ownership rule for /plugins/storage/volume/ontap.

Review effort: Balanced

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants